Bump version patch #1874
Merged
Bump version patch #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahar-p
force-pushed
the
bp/bump-version
branch
from
9815acd to
60701f8
Compare
bahar-p
commented
Dec 17, 2024
| @@ -5,7 +5,7 @@ class Tokenizer | |||
| attr_reader :line_number, :for_liquid_tag | |||
|
|
|||
| def initialize(source, line_numbers = false, line_number: nil, for_liquid_tag: false) | |||
| @source = source.to_s | |||
| @source = source.to_s.to_str | |||
There was a problem hiding this comment.
For posterity:
This is necessary to handle cases where to_s returns a subclass of String but we explicitly want to turn it into an instance of String.
As stated in this PR, ActiveSupport::SafeBuffer is one that we need to handle. It is a subclass of String. Calling ActiveSupport::SafeBuffer#to_s returns self (an instance of safe_buffer) however, what we actually want is an instance of String. Calling to_str ensures we're always dealing with an instance of String
There was a problem hiding this comment.
Can we just do?
Suggested change
| @source = source.to_s.to_str | |
| @source = source.to_str |
There was a problem hiding this comment.
to_str is only defined on String: https://docs.ruby-lang.org/en/3.3/String.html#method-i-to_str
mmorissette
approved these changes
Dec 17, 2024
ianks
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast follow on Fix bug in tokenizer with nil source value #1873 after digging further and getting more clarity on the why. Brought back the double string conversion,
to_s.to_str. See the comment as to why.Bump the version. Next minor release will be 5.6.0, bumping the patch version for semver compliance. I also added the latest fix in the Changelog for the release candidate. I'm sure there has been more if you have context feel free to add the update there.