Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue#295 issue#292: adding swagger and ui #324

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

VisionOra
Copy link
Collaborator

Relates to

issue #196

Background

create Endpoint to fetch logs from the database and integrate Swagger with it,

What kind of change is this?

create endpoint to fetch logs from database and integrate swagger as well, then show all logs on proper UI.

Why are we doing this? Any context or related work?

we are doing this for better visibility of generated logs

Where should a reviewer start?

run the api first with command
npm run dev --workspace=@sa-eliza/api

Database changes

setup database on my local work station

Realted to issue : #196

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VisionOra! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!

@VisionOra
Copy link
Collaborator Author

VisionOra commented Jan 31, 2025

npm run dev --workspace=@sa-eliza/api

@ArsalonAmini2024 @monilpat here is the command to run swagger for logging API

@monilpat monilpat changed the title add: issue#295 issue#292: adding swagger and ui feat: issue#295 issue#292: adding swagger and ui Feb 1, 2025
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM amazing work just some nits otherwise looks great :) Going to merge in but please address comments in your subsequent PR for the querying by room and agent :)

Comment on lines +23 to +26
console.log(`✅ Server running on ${process.env.BASE_URL}:${PORT}`);
console.log(
`📄 Swagger is available at ${process.env.BASE_URL}:${PORT}/api-docs`
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use elizaLogger instead everywhere thanks

Comment on lines +32 to 36




const storage = multer.diskStorage({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the newlines

@monilpat monilpat merged commit 2b2e40f into jure/196 Feb 1, 2025
5 of 6 checks passed
@monilpat monilpat deleted the sohaib/196 branch February 1, 2025 23:18
@monilpat
Copy link
Collaborator

monilpat commented Feb 1, 2025

Please resolve the merge conflicts and get it working in #275 so we can merge it into sif-dev. I will re-review once this is completed thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants