-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: issue#295 issue#292: adding swagger and ui #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VisionOra! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!
npm run dev --workspace=@sa-eliza/api @ArsalonAmini2024 @monilpat here is the command to run swagger for logging API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM amazing work just some nits otherwise looks great :) Going to merge in but please address comments in your subsequent PR for the querying by room and agent :)
console.log(`✅ Server running on ${process.env.BASE_URL}:${PORT}`); | ||
console.log( | ||
`📄 Swagger is available at ${process.env.BASE_URL}:${PORT}/api-docs` | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use elizaLogger instead everywhere thanks
|
||
|
||
|
||
|
||
const storage = multer.diskStorage({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove the newlines
Please resolve the merge conflicts and get it working in #275 so we can merge it into sif-dev. I will re-review once this is completed thank you :) |
Relates to
issue #196
Background
create Endpoint to fetch logs from the database and integrate Swagger with it,
What kind of change is this?
create endpoint to fetch logs from database and integrate swagger as well, then show all logs on proper UI.
Why are we doing this? Any context or related work?
we are doing this for better visibility of generated logs
Where should a reviewer start?
run the api first with command
npm run dev --workspace=@sa-eliza/api
Database changes
setup database on my local work station
Realted to issue : #196