-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NSIS install using $TEMP are flags matching rules #5152
base: master
Are you sure you want to change the base?
fix: NSIS install using $TEMP are flags matching rules #5152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @Ti-R 👋
It looks like this is your first pull request on the Sigma rules repository!
Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.
Thanks again, and welcome to the Sigma community! 😃
eg: https://www.virustotal.com/gui/file/2ed7c8bbdb728a53354849f2801a05dd9719ffe7984002d0cc1dbc5c17696b66 Matches rule Suspicious Volume Shadow Copy Vsstrace.dll Load by frack113 at Sigma Integrated Rule Set (GitHub) NSIS $TEMP is used like this: '$TEMP\vc_redist.x64.exe /install /quiet /norestart' Ideally, the exe to install should be signed by Microsoft from theses directories. So the rule should check if it is signed from Microsoft.
b4b49ac
to
4b0a5fe
Compare
Hi, To be more accurate, we can add a filter like this one: filter_vc_redist:
Image|startwith: 'C:\ProgramData\Package Cache\{'
Image|endswith: '}\VC_redist.x64.exe' # need the 86 name too :) |
Hi, |
Co-authored-by: frack113 <62423083+frack113@users.noreply.github.com>
Summary of the Pull Request
NSIS install using $TEMP are flags matching rules
Changelog
Example Log Event
eg:
https://www.virustotal.com/gui/file/2ed7c8bbdb728a53354849f2801a05dd9719ffe7984002d0cc1dbc5c17696b66 Matches rule Suspicious Volume Shadow Copy Vsstrace.dll Load by frack113 at Sigma Integrated Rule Set (GitHub)
Fixed Issues
NSIS $TEMP is used like this:
'$TEMP\vc_redist.x64.exe /install /quiet /norestart'
Ideally, the exe to install should be signed by Microsoft from theses directories. So the rule should check if it is signed from Microsoft.
SigmaHQ Rule Creation Conventions