Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-UP] Fix for access point power cycle rejoin issue with ecosystem #119

Conversation

senthilku
Copy link
Contributor

  • Added a join callback handler
  • The unnecessary join events have been removed. The join event is posted multiple times, causing issues with the ecosystem during AP power cycles.
  • The join retry limit has been removed. During the commissioning process, the MAX_JOIN_RETRIES_COUNT is set to 5, and this limit should be removed once commissioning is successful

Fixes https://jira.silabs.com/browse/MATTER-4379 and https://jira.silabs.com/browse/MATTER-4297

@senthilku senthilku requested a review from a team as a code owner November 21, 2024 10:58
@mkardous-silabs mkardous-silabs added the sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release. label Nov 21, 2024
Copy link
Contributor

@mkardous-silabs mkardous-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the new code being added, can we make sure it follow the coding standard?
https://confluence.silabs.com/display/MATTER/Silicon+Labs+Matter+Coding+Standard

@senthilku senthilku force-pushed the bugfix/rejoin_issue_after_reset_AP_DUT branch from 858f2dd to 980ba57 Compare November 27, 2024 10:49
senthilku and others added 9 commits November 28, 2024 05:16
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
senthilku and others added 4 commits November 28, 2024 22:36
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
@mkardous-silabs mkardous-silabs merged commit 29ada74 into SiliconLabsSoftware:release_2.5-1.4 Nov 28, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants