[SL-UP] Bugfix/matter shell crash nullptr #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
approved these changes
Nov 22, 2024
jmartinez-silabs
approved these changes
Nov 22, 2024
mkardous-silabs
added
the
sl-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the matter shell, a combination of:
backspace + enter or any special characters such as arrow keys would cause
ExecCommand to be call with argc > 0, but argv == nulptr, which would crash the app.
This was tested using UART logs and screen command.
Added a nullptr check to prevent the crashes, in the longterm we might want to investigate how the filtering left us with argc > 0 in those cases.