Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-UP] Bugfix: Hardware version persistence. #223

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[SL-UP] Bugfix: Hardware version persistence. #223

merged 2 commits into from
Jan 23, 2025

Conversation

rcasallas-silabs
Copy link
Contributor

@rcasallas-silabs rcasallas-silabs commented Jan 20, 2025 •
edited
Loading

  • Hardware version is now persistent over factory reset.
  • Migration function moved to the common library.
  • Fixes MATTER-4504.
  • Tested on BRD4187C.

@rcasallas-silabs rcasallas-silabs requested review from a team as code owners January 20, 2025 19:25
@rcasallas-silabs rcasallas-silabs changed the base branch from main to release_2.5-1.4 January 20, 2025 19:25
@jmartinez-silabs
Copy link
Contributor

The pr title needs the pr prefix.
Looking at the diff this should be [SL-UP]

@jmartinez-silabs jmartinez-silabs added the sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release. label Jan 20, 2025
@rcasallas-silabs rcasallas-silabs force-pushed the bugfix/hw_version-persistence branch from 557e3c0 to 00467d9 Compare January 21, 2025 17:36
@rcasallas-silabs rcasallas-silabs changed the title Bugfix: Hardware version persistence. [SL-UP] Bugfix: Hardware version persistence. Jan 21, 2025
@rcasallas-silabs rcasallas-silabs force-pushed the bugfix/hw_version-persistence branch from 00467d9 to 74b2201 Compare January 22, 2025 16:02
@rcasallas-silabs
Copy link
Contributor Author

The pr title needs the pr prefix. Looking at the diff this should be [SL-UP]

Done.

@mkardous-silabs mkardous-silabs merged commit 9ad24ac into release_2.5-1.4 Jan 23, 2025
41 of 52 checks passed
@mkardous-silabs mkardous-silabs deleted the bugfix/hw_version-persistence branch January 23, 2025 15:51
jmartinez-silabs pushed a commit that referenced this pull request Feb 6, 2025
@rcasallas-silabs @jmartinez-silabs
[SL-UP] Bugfix: Hardware version persistence. (#223)
178ae37
mkardous-silabs pushed a commit that referenced this pull request Feb 14, 2025
@rcasallas-silabs
[SL-UP] Bugfix: Hardware version persistence. (#223) (#37556)
d6ad867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

Assignees
No one assigned
Labels
sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcasallas-silabs @jmartinez-silabs @mkardous-silabs