Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-TEMP] Modified scan networks code to use ByteSpan in place of pointer. #257

Merged
merged 5 commits into from
Jan 30, 2025
Merged

[SL-TEMP] Modified scan networks code to use ByteSpan in place of pointer. #257

merged 5 commits into from
Jan 30, 2025

Conversation

arun-silabs
Copy link
Contributor

This PR fixes the Scan Networks issue mentioned in MATTER-4650

Description of issue : While scanning for a particular SSID(string), the size of the pointer to this string is taken as length of the string instead of the actual length.

Description of Fix : Replaced the pointer with Bytespan so that the length of the input SSID is calculated correctly.

@arun-silabs arun-silabs marked this pull request as ready for review January 28, 2025 16:57
@arun-silabs arun-silabs requested a review from a team as a code owner January 28, 2025 16:57
@mkardous-silabs
Copy link
Contributor

Can you list all the tests that were done to validated that the scan operations works under all scenarios?

@arun-silabs
Copy link
Contributor Author

Can you list all the tests that were done to validated that the scan operations works under all scenarios?

Sure.

  1. Scan with ssid passed as null - This will return all the available networks
  2. Scan with ssid passed as non-null string : If this SSID is found in the list of scanned networks, the details of that particular network are returned. If the SSID is not found, networkingstatus: 5 is returned.

@jmartinez-silabs jmartinez-silabs added the sl-temp This TAG indicates that this commit is silabs-specific that will not be upstream or carried over. label Jan 28, 2025
@jmartinez-silabs
Copy link
Contributor

@arun-silabs new Build failure to address

@arun-silabs arun-silabs force-pushed the bugfix/scan_networks_fix branch from 4174ea2 to 82670db Compare January 29, 2025 04:41
mkardous-silabs
mkardous-silabs requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@mkardous-silabs mkardous-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a request change to get the change to review later

@arun-silabs arun-silabs merged commit 639bb9a into release_2.5-1.4 Jan 30, 2025
52 checks passed
@arun-silabs arun-silabs deleted the bugfix/scan_networks_fix branch January 30, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senthilku senthilku senthilku approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

@rosahay-silabs rosahay-silabs rosahay-silabs approved these changes

Assignees
No one assigned
Labels
sl-temp This TAG indicates that this commit is silabs-specific that will not be upstream or carried over.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arun-silabs @mkardous-silabs @jmartinez-silabs @senthilku @rosahay-silabs