Sync csa branch with main #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…docker version 104 (#37188) * riscv: telink: add compile support for tl7218x . - fix retention ram. Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com> * riscv: telink: seperate ram for tl3218x . - use retention mode to seperate ram. - reserve more ram for ilm. Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com> * [Telink] Fix broken GitHub CI after adding tl721x target * [Telink] remove temporary LZMA for tl321x due to bug * [Telink] Add missed clean out build output step * [Telink] remove b95 SoC / TLSR9258a board (replaced by TL721x) * [Telink] Update builds to docker version 104 * [Telink] disable debug part * skip update of QEMU / Tizen * skip update of Tizen & Smoke Run - Android * skip update of Lint Code Base image --------- Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com> Co-authored-by: Haiwen Xia <haiwen.xia@telink-semi.com> Co-authored-by: haiwentelink <125550736+haiwentelink@users.noreply.github.com>
* Python test whl: Use zip files for data_model We are close to the input parameter limit for the builds with the number of files in the data_model directory as-is. With the addition of the 1.4.1 files, we go over. Instead, we can zip the files and have the parser read directly from the zip archive. I think this also makes the whl slightly smaller, which is nice. Spec parsing is tested directly with TestSpecParsingSupport.py and with TestSpecParsingDeviceTypes.py. The TC_DeviceConformance tests also use the parsed spec. * Fix generator script to make the build file in the new format * Add CI checker that build file matches generated * Add an intentional failure so I can see the CI trigger * Add the warning * Add back the CI failure trigger * whoops, missed the part where I check out the code * CI is hard and I am not good at it * Think I got it? Works on act * Revert "Add back the CI failure trigger" This reverts commit 38ad9565a21f63ce848c24f55c511c9d037033c2. * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py
…quests when building subject descriptors (#37174) * Support a new auth mode of "internal" * Restyle * Rename kInternal to kInternalDeviceAccess --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
* implement TC_FLABEL_2_1 with Python * use write_single_attribute method instead of WriteAttribute, remove debug logging * apply linter suggestion * replace @async_test_body with @run_if_endpoint_matches * address review comments * remove unused import * add description * add checks as per the test plan to check that LabelList tuples are of type string and have a length up to 16 bytes * remove yaml test, now has a Python implementation
* update docker for android * update base docker chip build version
…ainable. (#37338) * Prepare for capture testing... * Update test to look more sane * Update includes * More includes fixes * One more update * Restyled by clang-format * Fix types to make arm/xtensa compiles happy * Restyled by clang-format * Make clang tidy happy * Restyled by clang-format * Even more readable code * Restyled by clang-format * Update src/app/tests/TestReadInteraction.cpp Co-authored-by: Andy Salisbury <salisbury.andy@gmail.com> * Update src/app/tests/TestReadInteraction.cpp Co-authored-by: Andy Salisbury <salisbury.andy@gmail.com> * Update src/app/tests/TestReadInteraction.cpp Co-authored-by: Andy Salisbury <salisbury.andy@gmail.com> * Removed odd todo --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andy Salisbury <salisbury.andy@gmail.com>
* Fix invoke verification of data existence of cluster and endpoint * Add unit test for codegen logic issue * Add integration test for return codes * Restule * Remove odd comment * Remove unused import * Use asserts fail * Add unit test that checks invalid cluster return code as well * Fix comment * Code review feedback: listing of commands should fail if the cluster does not exist * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Updated comment * Try to reduce amount of code overhead for extra validation check * Update logic yet again since just checking for null fails unit tests and having unit tests seems reasonable * Restyle * Update src/data-model-providers/codegen/EmberMetadata.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/EmberMetadata.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update comment * Update comment * Update based on code review ... if we cannot enforce an interface, we document. Not happy and hoping we can improve in the future --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Andrei Litvin <andreilitvin@google.com>
|
The check for |
…d for them. (#37344) * Add MTRDeviceController API to get a list of node IDs with data stored for them. To avoid races between modifications to _nodesWithResumptionInfo and our reading it, added a lock to protect _nodesWithResumptionInfo. Also added a cached _nodesWithAttributeInfo (protected by the same lock) so that we don't have to do a sync dispatch to our storage queue to return a value from this API. * Fix unit test that was relying on the storage being the source of truth for the node index.
…oner (#37346) * Fix compilation errors for android-chip-tool and java-matter-commissioner - Corrected logging statement syntax in `AndroidLogDownloadFromNode.cpp` - Fixed type casting issue for `jlong jremoteNodeId` - Resolved incorrect pointer dereference causing a misplaced operation in `OnTransferCallback` - Updated type casting for `msg_length` in `CHIPP256KeypairBridge.cpp` to use `jsize` instead of `uint32_t` - Adjusted JNI function call to use `static_cast<jsize>(msg_length)` These changes ensure compatibility with JNI and address type inconsistencies that were causing build failures. Testing: ```bash export PATH=$PATH:/opt/kotlin-compiler-1.8.0/bin export ANDROID_HOME=/opt/Android/sdk/ export ANDROID_NDK_HOME=/opt/Android/sdk/ndk/23.2.8568313 export JAVA_HOME=/Library/Java/JavaVirtualMachines/amazon-corretto-11.jdk/Contents/Home export JAVA_PATH=/Library/Java/JavaVirtualMachines/amazon-corretto-11.jdk/Contents/Home sed 's/ -XX:MaxPermSize=2048m//' examples/android/CHIPTool/gradle.properties > examples/android/CHIPTool/gradle.properties.new && mv examples/android/CHIPTool/gradle.properties.new examples/android/CHIPTool/gradle.properties source scripts/activate.sh ./scripts/build/build_examples.py --target android-arm64-chip-tool --target darwin-arm64-java-matter-controller build ``` * fix: Cast GetFabricIndex() return value to jint in AndroidLogDownloadFromNode The change adds an explicit static cast to convert the FabricIndex return value to jint type when assigning to jFabricIndex variable, maintaining type safety in the JNI interface layer.
* [ESP32] update document for app_main outside of main component Earlier, we needed to fetch and link the components separately. In #36883 we started using `add_prebuilt_library()` so there is no need to explicitly specify the executable component. * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io>
mkardous-silabs
approved these changes
Feb 3, 2025
mykrupp
approved these changes
Feb 3, 2025
* jupyterlab-git * Update Basic Interactions Notebook * Update Notebook: Access Control * Updating Multi Fabric Notebook * replace deprecated API get_loader * import chip.clusters within script * doc fix * Running Jupyter as part of CI
* Update with review comments from 37127 * Addressing more comments * One more comment update * Restyled by clang-format * Update src/app/data-model-provider/ProviderMetadataTree.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Update Kotlin / gradle version in Android Chiptool * Change Java version * Update to Java 11 * Revert Dockerfile Version * Update version * install cmdline tools * Use 105 image * Update smoketest-android.yaml * Update android.py with latest sdk path * Revert "Update android.py with latest sdk path" This reverts commit 864dc0e5a9ffe167f392ca0adb839dc66aa449fb. * Fix compilation errors -- Use docker 106 -- Remove unsupported -XX:MaxPermSize=2048m -- Update java version * bump classpath gradle to 7.1.3 for other android build * update the rest gradle across tress * bump class path to 7.3.3 as well * Revert "bump class path to 7.3.3 as well" This reverts commit 1cd60b06756449eec3da15d7c2130519a880124c. --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: yunhanw-google <yunhanw@google.com>
…… (#37324) * Handle the output event of type TransferSession::OutputEventType::kInternalError in the ProcessOuputEvents processing loop - The transfer session state machine generates an output event of type TransferSession::OutputEventType::kInternalError in certain error scenarios which put the transfer session in a bad state and when that happens, we need to unwind the processing loop for events and clean up. * Update src/protocols/bdx/AsyncTransferFacilitator.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Address review comments * Update src/protocols/bdx/AsyncTransferFacilitator.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION