Sync csa branch with main #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Post-merge review highlighted a few more updates. Performed them here.
* Fix deregistering error formatter * Don't dereference address pointed by lfp in for loop expression as it may be a nullptr. * Add simple test that registers and deregisters single error formatter. * Deregister all formatters at the end of CheckRegisterDeregisterErrorFormatter. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Fix error formatter tests * Add function to deregister CHIP layer error formatter. * Deregister CHIP error formatter at the end of tests to not interfere with other tests. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
The log sounded like a retransmit was happening, but it's actually saying that a retransmit is scheduled. The retransmit might or might not happen, depending on whether we get an ack before the scheduled time.
* Add semicolon to fix compilation failure on MacOS * Fix indent
* [Tizen] Use 7zip for extracting RPM files * Download all packages from dedicated Tizen version
…mproved Testability (#36941) * - Creating an overload of DecodeMRPParametersIfPresent that takes SessionParameters as an outparam and does not touch PairingSession class member mRemoteSessionParameters - a utility SetRemoteSessionParameters to be able to set PairingSession class member mRemoteSessionParameters * Making ParseSigma1 static and not dependent on class state * factoring out ParseSigma2 * factor out Parser for decrypted Sigma2 * various cleanup * factor out ParseSigma2Resume * Adding Unit Tests * More Various Cleanup * Factor out ParseSigma3 and ParseSigma3TBEData * Unit Tests for ParseSigma3 and ParseSigma3TBEData * Code Cleanup * Integrating Comments and Adding comments * Increase Coverage of TestSigma1Parsing * Integrating Comments * Integrating comments
…P_HAVE_CONFIG_H (#37366) * [chip-tool] include crypto/CryptoBuildConfig.h must be guarded by CHIP_HAVE_CONFIG_H Minor fix to unguarded include. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Add 1.4.1 as a direct copy of 1.4 This can be used to see a diff between these two releases * Update alchemy version on 1.4 changes contraints - will update on tot soon, but don't want to wait for the PR to land before this goes in. * data model files at the 1.4.1 tag * Add 1.4.1 data model files to the CI checks * Add 1.4.1 files to the python build * Add 1.4.1 to parser with tests. * Fix spec revision differ script * Restyled by isort --------- Co-authored-by: Restyled.io <commits@restyled.io>
The test plan states that the test should wait till the time is over. The current test waits exactly as long as the window is. If there are cases where on the DUT the timers are not that accurate this "very exact check" could lead to false positives. We had such cases with matter.js in the CI here and there because Node.js Timers are not 100% accurate and depending on other tasks in the event loop closing the window could be slightly delayed. One CI example can be seen in https://github.com/project-chip/matter.js/actions/runs/12964616630/job/36163527843#step:4:3695 The analysis of a comparable showed this: * 10:17:46.984 matter.js enables the timer for 180s * 10:17:46.987 matter.js send InvokeResponse * 10:17:46.989 till 10:20:46.989 test-runner wait, so exactly 180s * 10:20:46.992 we get the read and we are still on "window opened" * 10:20:46.994 we close the window - 10:20:46.996 trx is unlocked so done So the test did the read 4ms too early. This proposal could make this test a bit more false positive secure also for prodiction certifications.
…37268) * Change reference from TLV endpoint * Change test endpoint function * Fix issue with attr list * Add handling for TLV attributes
|
The check for |
mkardous-silabs
approved these changes
Feb 5, 2025
jmartinez-silabs
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION