Sync csa branch with main #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ovider (#37345) * A first pass to add global attributes as part of IME instead of datamodel::provider * Some updates * Update some tests and reformat... the checks were PAINFUL,kept debug logs * Bump test: we now support the extra 3 global attributes not in metadata * More fixes * Fix compile error about parameter shadowing * More updates on casts to make xtensa compile happy * Restyled by clang-format * Fix tests * Make the test for unsupported write consistent with #37322 * Fix includes * Smaller delta * Attribute metadata is now guaranteed * Update src/app/data-model-provider/MetadataLookup.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataLookup.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/reporting/Engine.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Address some code review comments * Remove the ember metadata public cluster path validation as it is not needed anymore as a public API * Do not enforce ordering in attribute list encoding * Comment about items returned or not returned in various calls * Correct the unsupported attribute call * Restyle * Update order dependent test in java ... this is somewhat broken... * Fix indent * Fix include * Fix typo * Allow TODO comment: I am not willing to re-build the kotlin code right now for this PR * Using uint64_t for encoding saves some flash * Fix test ... although this is NOT ok as we need order independent test * Fix the real list now * Switch the basic information constraints as a set compare (use python) * Remove extra space * Restyled by prettier-yaml * Fix asserts in DGWIFI - wrong method used * Restyled by autopep8 * Update src/app/data-model-provider/Provider.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/ProviderMetadataTree.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/CodegenDataModelProvider_Write.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/ProviderMetadataTree.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Undo DFWIFI changes, leave it up to #37382. * Update ordering of attribute list to match unsorted (and smaller) implementation in the SDK * Update src/app/GlobalAttributes.cpp Co-authored-by: Terence Hampson <thampson@google.com> * Update src/app/GlobalAttributes.h Co-authored-by: Terence Hampson <thampson@google.com> * Add comment about oddify in path validation * Added comments about why we do the casts ... it is ugly * Add integration test for writing read only attributes and getting the correct error * Restyled by isort * Fix unused imports --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Terence Hampson <thampson@google.com>
…(#37416) The old naming was too confusing, and this more accurately represents what is actually going on.
* Make the build_coverage script more flexible * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Delete fialize method in java * Restyle
* Add test steps logging for TCP Tests * Fix naming of Test steps.
…document. (#37098) * Test Steps 2, 3, 4, 2a, 3a, 4a, 2b, 3b, 4b,6, 7, 8, 10, 13 are updated with the boolean flag(SendInitMsgfromDUT ) true and false condition * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
…pt (#37337) * [PSA] bugfix for potential buffer overflow from AES_CCM Encrypt/Decrypt * Integrating Comments * Integrating comments
* [Darwin] MTRDevice should tear down subscription on dealloc * Update src/darwin/Framework/CHIP/MTRDevice_Concrete.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDevice_Concrete.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Fix log line. * Make sure that _persistClusterData only notifies delegates when persistence actually happens. * Fix unit test to wait for delete properly --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Justin Wood <woody@apple.com>
* [#36594] TC_SC_4_1, make BCM optional to meet test plan * [#36594] Remove new line * Restyled by prettier-yaml * Add ICDM.S.A0002 checking(#36597) * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <commits@restyled.io>
Don't build test vectors if not building tests. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…7425) * Make ConstructTBSData outparam a MutableByteSpan instead of a Pointer + Len * Adding a msgR2Decrypted struct member to improve clarity * Clarifying Logs when Assigining Peer SessionID * Removing TODO on validating signature before validation credentials * changing Logs to ScopedNodeID instead of just NodeID
* Auto-select data model set based on specification version * Remove extra includes * Fix PICS test test to add SoftwareVersion with pics * Restyled by isort * linter * Omit TestSpecParsingSelection test from app testing --------- Co-authored-by: Restyled.io <commits@restyled.io>
…… (#37412) * Reduce logging in BDXTransferSession by removing logging for BlockQuery, Block and BlockAck messages as they generate a lot of logs - The Exchange Manager alreadys logs the BlockQuery, Block and BlockAck messages and that can be used for debugging purposes - Do not log messages for OutputEvent when the event type is None - Also reduce additional logging in the darwin code. * Restyle * Address review comments * Fix whitespace restyled issue. --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
The check for |
…stom AAI classes (#37351) * Allow custom AAI registration for PwRPC Reads/Writes. Update PwRPC Writes to look for custom AAIs before using datamodel provider * Add succes log * Make TryWriteViaAAI public * Make TryWriteViaAAI public * Fix compilation errors * Fix compilation errors * Fix compilation errors * Update examples/common/pigweed/rpc_services/Attributes.h Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Add new attribute accessor and registry for PwRPC * Fix compilation error * Fix compilation error * Fix compilation error * Revert changes * Revert changes * Accessors will not be indexed by EndpointId/ClusterId. Caller queries all accessors to satisfy the request and returns as soon as a succes/failure is encountered. Accessors will return 'pw::Status::NotFound()' as a way of hinting the caller 'look for an alternative'. If no accessors were registered or all returned 'NotFound' the fallback path is taken. * fix compilation bug * Review comments * Fix compilation * Fix nits * Fix ESP32 compilation * Update examples/common/pigweed/rpc_services/AccessInterceptor.h Nit : rename parameter names. Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update examples/common/pigweed/rpc_services/AccessInterceptor.h Review suggestion. Co-authored-by: Andrei Litvin <andy314@gmail.com> * Update examples/common/pigweed/rpc_services/AccessInterceptorRegistry.h Review suggestion. Co-authored-by: Andrei Litvin <andy314@gmail.com> * Review comments * Update examples/common/pigweed/rpc_services/AccessInterceptor.h --------- Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
The response array for this case can have any number of entries, not just one.
This reverts commit d777dce.
* Change pm10 unit from ppm to micrograms per cubic meters * Fix bug - micro is U not M
* [Darwin] MTRDevice should throttle deviceBecameActive callbacks * * Use a slightly shorter interval with its own define for deviceBecameActive throttling. * Log when we start throttling deviceBecameActive callbacks. --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
mkardous-silabs
approved these changes
Feb 7, 2025
* Add ifdef * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
When running workflow locally using `act`, `Save bootstrap cache` step takes significant amount of time. This is caused by missing `zstd`. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…t (#37444) * upgrade android sd to android 11 with java 11 support * Update Dockerfile --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
- modify lighting-app telink REDME.md file Signed-off-by: Borys Nykytiuk <borys.nykytiuk@telink-semi.com>
ExampleAccessRestrictionProvider.h had a comment referring to an event from a development iteration that was incorrect. Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Update TC_OCC_3_2.py Fixed 4d test step failure by removing legacy attributes and streamlining attribute subscription test. * Update TC_OCC_3_2.py * Update TC_OCC_3_2.py * Update TC_OCC_3_2.py * Update TC_OCC_3_2.py * Update TC_OCC_3_2.py
* Move OnboardingCodesUtil out of server * Move OnboardingCodesUtils to separate target. * Remove shell dependency on server. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [mw320] Remove shell dependency on app/server Use PlatformMgr directly. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [NXP][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [linux][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [Infineon][examples] Add missing dependency Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…… (#37052) * Add test steps 50-60 from the Thermostat test plan to the Thermostat YAML script - Remove Test_TC_TSTAT_4_1.yaml * Restyle * Rename TC_TSTAT_4_2.py to TC_TSTAT_2_3.py * Address review comments * Revert renaming TC_TSTAT_4_2.py to TC_TSTAT_2_3.py * Add check for the Presets list length that should not exceed the value in NumberOfPresets attribute * Editorial fix * Revert the name change from TC_TSTAT_4_2 to TC_TSTAT_2_3 * Update minLength and maxLength in YAML to take a variable as input * Restyle
…#37283) * Optimize flash cost for optional command in wifi diagnostic cluster * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
…sionOutput. (#37458) We get a lot of them because of the polling setup, and all they mean is "we have not gotten the next thing from the other side yet".
Some typos crept in, and the function argument name was sub-optimal.
…st steps 1 and 2 (#37424) * Updated TC-DD-1.10 YAML script with more detailed descriptions for test step 2 and 3 * Restyled by whitespace * Updated the TC-DD-1.10 Yaml script with missing details * Restyled by whitespace * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <commits@restyled.io>
- Fixed the build issue due to missing bits in bluedroid BLEManagerImpl. - Added extended ble advertising support.
* Update TCUpdateDeadline to be nullable to match spec * Empty-Commit * Add xml file * re-add option=true * regen
* Emable python tests during coverage * Enable integration test during coverage statistic * Update build_linux_gcc_coverage
jmartinez-silabs
approved these changes
Feb 8, 2025
Log self and the method involved, so we know what's failing on what objects.
jmartinez-silabs
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION