Sync csa branch with main #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* test: Implement TC acknowledgement test cases 2.5-2.8 Implements test cases for Terms & Conditions acknowledgement verification: - TC-*-2.5: SetTCAcknowledgements verification - TC-*-2.6: CommissioningComplete with no terms accepted - TC-*-2.7: CommissioningComplete with invalid terms - TC-*-2.8: TCAcknowledgements reset after Factory Reset Remaining test cases to be implemented in follow-up changes: - TC-*-2.9: Reset after fabric removal - TC-*-2.10: Required terms validation - TC-*-2.11: Post-commission updates Testing: Test cases implemented according to test plan specifications. Each test verifies specific TC acknowledgement behaviors. * test: Implement remaining TC acknowledgement test cases 2.9-2.11 Implements remaining test cases for Terms & Conditions acknowledgement verification: - TC-*-2.9: TCAcknowledgements reset after fabric removal - TC-*-2.10: Required terms validation - TC-*-2.11: Post-commission TC updates This completes the test coverage for TC acknowledgement verification, following up on the previous implementation of test cases 2.5-2.8. The new test cases verify: - TC state after fabric removal - Protection of required terms - Ability to update TC version and acknowledgements post-commissioning Testing: Test cases implemented according to test plan specifications. Each test verifies specific TC acknowledgement behaviors. * wip * feat(testing): Add PICS guard for Terms & Conditions test steps - Wrap test steps in PICS guard checks for "CGEN.S" and "CGEN.S.F00(TC)" - Ensure test steps only execute when Terms & Conditions feature flag is enabled - Maintain test logic while adding conditional execution based on PICS support * Added PICS and PIXIT definitions to src/app/tests/suites/certification/PICS.yaml * refactor: Extract commission_devices functionality into reusable methods Move commissioning logic from CommissionDeviceTest class into standalone functions to improve code reusability. Introduce CommissioningInfo dataclass to encapsulate commissioning parameters and add commission_device/ commission_devices helper functions. The changes: - Move SetupPayloadInfo dataclass to module level - Add new CommissioningInfo dataclass for commissioning parameters - Extract commission_device and commission_devices as standalone async functions - Add commission_devices method to MatterBaseTest class - Maintain backward compatibility with existing usage in CommissionDeviceTest * Addressed PR comments * Improve test assertions and manual testing steps - Use Matter-specific type assertions in TC_CGEN_2_5 - Update TC_CGEN_2_8 manual testing flow and prompts * restyle * refactor: simplify CGEN feature identifier from CGEN.S.F00(TC) to CGEN.S.F00 - Update PICS.yaml and ci-pics-values to use simplified feature ID - Update Python test files to use new feature identifier - Improve error messaging when commissioning feature check fails - Affected test files: TC_CGEN_2_5 through TC_CGEN_2_11 * Update TC_CGEN_2_5 to use Nullable type for TCUpdateDeadline validation * Add type validation for TCAcceptedVersion and TCAcknowledgements
Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes: - Adding build target for terms-and-conditions app - Copying the built binary to the final image - Adding environment variable reference in CI test configuration This addition will support upcoming CI test requirements for the terms and conditions functionality.
|
The check for |
mkardous-silabs
approved these changes
Feb 10, 2025
* [Telink] Manual Zephyr SDK update to check CI jobs * [Telink] Update Zephyr revision & remove dev changes * typo
* Fix regular expression for variable splitting. Previous code tried to escape every character, however python linters complained about illegal escapes. The expression also seemed a bit complex, so a character set seems clearer. * Add brackets to force separator to also exist in the split
…7498) Add additional test steps to verify TC-related attributes before sending CommissioningComplete: - Verify TCAcceptedVersion equals 0 - Verify TCAcknowledgements equals 0 - Verify TCAcknowledgementsRequired equals True
…`-fcoverage-mapping/-fprofile-instr-generate` (#37457) * Add coverage support flags (but no save yet for the flag) * Minor cleanup, save config options when loading variants, so build flags transcend running * Fix yaml content * Restyled by isort * Switch coverage to clang, ensure out dir for config exists * Slight doc update, allow local.py to use ccache * Start adding filter support and comma separation support to local.py * Fix the runner termination logic * gen-coverage works * Restyle * make linter happy * Make it clearer what errors we ignore, add more error logic to make this run on more machines * Restyle * Add more ignores for cleaner results * Restyle * One more ignore * Better organization, make paths consistent * Fix logic. Merged reports now work! * Restyle * fix stderr logging * fix fail dir creation * Make mismatched FIFO pid much easier to investigate * Add hierarchical view by default - it seems easier for us to narrow down coverage * Add coverage support for yaml * Use exec to execute the sub-program * Fix up arguments in local.py to support propper quoting * For chip tool tests also run chip-tool with coverage support * Fix the path-variance runs of unit test, so I can run unit tests with coverage * Updated comment a bit * Increase timeout for test running to cover slow tests, skip slow tests or tests that we know will fail * Also exclude manual tests by default from local runs * match default exclusions ... also flaky excluded * Support keep going for yaml tests, add more ignores * Multiprocessing coverage, coverage now works * Add missing assignment * Restyled by autopep8 --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io>
…#37506) * [Darwin] Support MTRCommandWithRequiredResponse being nested in XPC When secure decoding MTRCommandWithRequiredResponse as part of [MTRDevice deviceController:nodeID:invokeCommands:completion:], it needs to list all classes that be part of the commandFields and requiredResponse fields. When double nested XPC will only assume to decode NSDictionary of basic type. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Initial generated test * Fixed and compared against test plan * Remove unused TC-TSTAT-2.2 yaml * Apply suggestions from code review Co-authored-by: fesseha-eve <88329315+fessehaeve@users.noreply.github.com> * Update TC_TSTAT_2_2.py fixed below mentioned discrepancies on the code: Step-3c: The test plan expects a Success response, but the script is checking for a ConstraintError. If the value does not violate any conditions, the response should be Success. In such cases, the test will fail. Step-4c: If the AUTO feature is enabled, the script writes the UnoccupiedCoolingSetpoint attribute with MaxCoolSetpointLimitValue and checks for a ConstraintError response, which is not required. Step-5c: The script should check the following condition when the AUTO feature is enabled: Min(MaxHeatSetpointLimit, (UnoccupiedCoolingSetpoint - MinSetpointDeadBand)). However, this condition is missing in the script, and it incorrectly checks for a ConstraintError response. Step-7a: The write and read verification is missing. Step-9b: The script incorrectly writes the attribute value using AbsMinCoolSetpointLimitValue instead of MinCoolSetpointLimitValue. Step-9c: A duplicate read check has been removed. * Python linter fix for TC_TSTAT_2_2 * Update src/python_testing/TC_TSTAT_2_2.py Co-authored-by: Nivi Sarkar <55898241+nivi-apple@users.noreply.github.com> * Restore setpoints to original values at end of test * Use get_endpoint method to find active endpoint * Update CI Test Arguments to the apparent new style --------- Co-authored-by: fesseha-eve <88329315+fessehaeve@users.noreply.github.com> Co-authored-by: Kishok G <133193761+KishokG@users.noreply.github.com> Co-authored-by: Nivi Sarkar <55898241+nivi-apple@users.noreply.github.com>
…cker version 112 (#37356) * [Telink] simplify WS2812_STRIP config * [Telink] Fix targets configs * [Telink] Use HAL mac_init functions directly * [Telink] disable PM for window app * [Telink] Fix Zephyr warning & use k_work_delayable_from_work * [Telink] Remove duplicate config * [Telink] clean-up Kconfig files * [Telink] clean-up enable-gnu-std.cmake * [Telink] Remove continue-on-error * [Telink] Fix/Enable BLE optimization * [Telink] Optimize MCUBoot log level configs * [Telink] use common SOC configs for different Zephyr versions * [Telink] Change Window Covering App default SoC W91 doesn't support PM * [Telink] Reduce mcuboot partition size * [Telink] Use 4mb flash for B92 till driver sdk update * [Telink] B92 update * [Telink] Remove temp b92 4mb change * [Telink] Update Zephyr revision * [Telink] Update builds to docker version 112 * Keep [Lint Code Base] image on version 98 Keep [Smoke test - Android] image on version 108 * Keep [Java Tests] image on version 104
…dling (#37322) * Move write validity inside the write handler rather than requesting the datamodel provider to perform the checks * Restyle * A bit of code cleanup and reuse, to minimize flash impact * Restyle * Drop the mPreviousSuccessPath, making objects smaller and saving yet another small amount of flash * Cleanup some includes * Restyle * Remove obsolete tests from codgen, as we do not do more validation now * Test write interaction passes * Test write passes * Slight clarity of code update * Fix comment * Manual check for last written saves 16 bytes of flash on QPG. * Status success is 2 bytes smaller in code generation than CHIP_NO_ERROR * Not using endpoint finder saves flash * Clean up code. We now save flash * More flash savings by reusing the server cluster finder * Update src/app/data-model-provider/MetadataLookup.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataLookup.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/Provider.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataLookup.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Updated comment * Hoist "writing" log up in processing, to preserve similar functionality * Code clarity updates * Fix includes and update the code AGAIN because it does seem we use more flash * Fix unsupported write on global attributes * Fix includes * Update src/app/WriteHandler.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Post merge cleanup * Fix merge error --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Also logs the SSID when doing commmissioning onto a Wi-Fi network.
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Correct spelling of "toggle" in README. Signed-off-by: Maddy Marsh <m-marsh@ti.com>
…37453) - Add optional `allow_empty` parameter to control empty list validation - Reorder function parameters for better readability - Update function docstring to clarify new behavior - Update test cases
…mostat-server (#37314)
* Fix line endings for master DM XMLs * Add newline at end of file for master DM XMLs * Add closures as a file exception - device types all in one file * DM XMLs: Update master to 0.7 of 1.5 and use alchemy Note that this contains a significant number of changes in one commit, and I apologise for that, but the new spec cannot be scraped with the DM editor, so I needed to swap to alchemy to get the new spec scraped. Hence this contains both the alchemy formatting changes (as outlined in project-chip/connectedhomeip#37201 as well as the changes from the last ballot to the current ballot. * Update file list in build file * Fix unit tests to expect clusters removed in 1.5 * Update device type parsing to warn on non-int IDs rather than failing This happens on ID-TBD in the ballot. * Add test to ensure all spec device types are OK. * Add a stringifier to XmlFeature XmlCommand * Restyled by autopep8 * Restyled by isort --------- Co-authored-by: Restyled.io <commits@restyled.io>
…… (#37454) * [bouffalo lab] update scripts and documents to support more options to generate and download test mfd * Restyled by prettier-markdown * Restyled by autopep8 * Restyled by isort * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io>
…… (#37516) * [bouffalolab] update macro define for header reserve size and ethernet zap configuration * re-generate lighting-app-ethernet.matter
…7517) * [bouffalo lab] open commission window when last fabric is removed * Restyled by whitespace * fix compile error --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [Darwin] Add logging for sync storage duration over a threshold * restyled * Clarify constant name per review comment
ReadClient does this, but we are not using its backoff logic.
jmartinez-silabs
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION