Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSA-CP] Cherry pick the OTA fix (CSA PR #37643) #317

Merged

Conversation

selissia
Copy link
Contributor

@selissia selissia commented Mar 6, 2025

Cherry pick project-chip/connectedhomeip#37643 "Check if a duplicated provider is present before loading into RAM"

Testing

CI

…7643)

* [Silabs] Check if a duplicated provider is present before loading it to RAM

* [Silabs] Added change requested by bzbarsky-apple

* Restyled by clang-format

* Fixed codereview request

* Fixed unit test issues

* Restyled by clang-format

* Make ProviderAlreadyInList public instead of private

* Update src/app/clusters/ota-requestor/DefaultOTARequestorStorage.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Should return false if the check is made on an empty list

* Fixed unit test, removed GetListSize and put back ProviderAlreadyInList as a private member

* Fixed unit test

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@selissia selissia requested a review from a team as a code owner March 6, 2025 16:28
@selissia selissia merged commit 9dd2016 into SiliconLabsSoftware:release_2.5-1.4 Mar 7, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants