-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync csa branch with main #320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we will only notify once if we get Add notifications all together on multiple interfaces.
…onForEviction (#37903) This commit renames the Python function CloseSession to MarkSessionDefunct to better reflect its actual behavior and align with the C++ API. The function marks a session as temporarily defunct when there's a suspected loss of synchronization with the peer, but allows the session to become active again if messages are received. Additionally, adds a new function MarkSessionForEviction that permanently marks a session for removal by detaching all SessionHolders and releasing references, which will deallocate the session if no references remain. Once marked for eviction, the session can never become active again. Both functions have been properly documented to explain their behavior, parameters, and differences. All references to CloseSession throughout the codebase have been updated to use MarkSessionDefunct.
…#37896) nimble_port_init() on idf v5.0.1 and prior returns void, and from v5.0.2 it returns esp_err_t.
…der (#37851) * Use server cluster interface in codegen data model * Self review: fix a header path and placement * Self review: fix comment * Undo submodule update * Self review: fix append capacities and reservations * one more error check added * Update src/lib/core/CHIPError.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/lib/core/CHIPError.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server-cluster/ServerClusterInterface.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Strong const correctness into the contexts * Remove `NotifyAllAttributesChanged` * Empty provider updated * Update comment and clarity for clusters on endpoint usage * Restyle * Some unit testing added * I believe simple loop will be smaller code than std::distance * More test coverage * ensure proper init and shutdown during tests as these contexts and registries are now sensitive * slight cleanup for style --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Andrei Litvin <andreilitvin@google.com>
* Generated using: ./alchemy zap --attribute="in-progress" ... /TLSClientManagement.adoc * Apply review comments & re-run alchemy * Generated using ./scripts/tools/zap_regen_all.py * Workaround for project-chip/zap#1255
* Fix compiler errors * Minor updates from spec PR CHIP-Specifications/connectedhomeip-spec#10794 * Run ZAP tool * Generated using ./scripts/tools/zap_regen_all.py * Workaround for project-chip/zap#1255
The check for |
Two issues: 1. If we got an error we did not log it. 2. If we got an error we did not actually propagate it out to the API consumer.
mkardous-silabs
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up PR will be necessary to fix the ZAP generation.
…#37905) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.5 to 3.1.6. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.5...3.1.6) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION