Sync csa branch with main #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Add rule to fast compile all existing chef devices * Comment informing about excluded devices * Restyled by autopep8 * Add job timeout of 60 mins for compile all chef --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
* Rename Ble*Delegate headers to match .mm / class names * Simplify BLEManagerImpl, we don't need to allocate the DelegateImpls separately * Add some tests that exercise BLE code by mocking Core Bluetooth Build with Bluetooth enabled in CI and enable Bluetooth mocking for all tests. * Retain the underlying CBPeripheral in MTRCommissionableBrowserResult This avoids a dangling pointer if the BleConnectionDelegateImpl drops the peripheral from the cache while a client still holds the browser result. Also document what BLE_CONNECTION_OBJECT is on Darwin. * Use the CHIP queue instead of a separate BLE queue * Tidy up BLE delegate headers * Factor out connObj bridge casts into helper functions * Simplify UUID handling, CBUUID does most of it already * Review comments / tidyup Add assertChipStackLockedByCurrentThread() to CB delegate methods. Use assign instead of unsafe_unretained for non-retainable types. Add comment to BLE Base UUID. * Avoid leaks false positive in CoreBluetooth mock * Final round of review comments
…ork for reading DCL content (#37964)
* Initial implementation of WebRTC Provider cluster * Fix link error * Address review comments * Report Attribute Change * Address review comments * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.cpp Co-authored-by: Andrei Litvin <andy314@gmail.com> * Simplify status result check * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update scripts/tools/check_includes_config.py Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Align with spec update * Addree review comments * Responds with CONSTRAINT_ERROR status if StreamUsage is not supported * Return ResourceExhausted if validate the stream usage * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * restyle * Address review comments * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Address review comments * Update src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update comments --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Integrate libdatachannel lib with camera apps * Fix build path * Restyled by gn * Fix build issues * restyle * Update BUILD.gn Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
The check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION