[SL-UP]modified to support si917 #346
Conversation
Sarthak-Shaha
changed the title
| #include <sparkfun_sgp40.h> | ||
|
|
||
| #if (defined(SLI_SI917)) |
There was a problem hiding this comment.
This define is set to true for the SoC and NCP configuration. Wouldn't work for the efr32 + 917 NCP
There was a problem hiding this comment.
@mkardous-silabs What is the correct way to verify if its a 917 soc device?
#if SLI_SI91X_MCU_INTERFACE ?
There was a problem hiding this comment.
Also, the app is not available for NCP combinations.
We do not support Sparkfun sensor with CSA.
There was a problem hiding this comment.
SLI_SI91X_MCU_INTERFACE is the define for SoC.
There was a problem hiding this comment.
Based on the customer issue that brought this feature to light; nothing prevent a customer to have efr+917ncp and try to use the airquality sensor feature.
There was a problem hiding this comment.
ok. This code is copied as is from https://github.com/SiliconLabs/third_party_hw_drivers_extension/blob/master/app/example/sparkfun_air_quality_sgp40/app.c#L42 I will confirm with them if NCPs were considered. At least they do not support the app for the NCPs https://github.com/SiliconLabs/third_party_hw_drivers_extension/blob/master/templates.xml#L862
Need to support si917 boards.
Added support for si917 , referenced from https://github.com/SiliconLabs/third_party_hw_drivers_extension/blob/master/app/example/sparkfun_air_quality_sgp40/app.c
Testing
Studio