[CSA-CP] BaseApplication common LCD Init #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykrupp
approved these changes
Mar 17, 2025
|
@lpbeliveau-silabs Reminder to put the SL TAG in your title minimally and Label as a plus |
jmartinez-silabs
changed the title
jmartinez-silabs
added
the
csa-cp
jmartinez-silabs
approved these changes
Mar 17, 2025
jmartinez-silabs
merged commit e74907f
into
SiliconLabsSoftware:release_2.6-1.4
53 checks passed
|
|
||
| #define BLE_DEV_NAME "SiLabs-EVSE" | ||
| #define BLE_DEV_NAME "SL-" APP_TASK_NAME |
There was a problem hiding this comment.
If we standardize this, it could be an idea to move this to a common configuration
#ifndef BLE_DEV_NAME
#error APP_TASK_NAME missing app task name
#define BLE_DEV_NAME "SL-" APP_TASK_NAME
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all LCD init into BaseApplication to reduce code duplication.
Added the recent BaseApp change in the dishwasher app.
Standardized BLE_ADV naming with app display naming.
Testing
Compile & Flash app with app name on display such as: light app, dishwasher app, etc.