[SL-UP] Button handling in dimmer-switch app #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue : MATTER-4819
This PR fixes the button handling issues seen in light-switch application. When the light-switch app has been extended as dimmer-switch app by adding level control cluster, the button functionality was changed. Button0 handling was moved from baseApplication to LightSwitchMgr. Due to this, a few features on Button0 short-press are missed.
In this PR, moved the button handling from LightSwitchMgr to AppTask (similar to all the apps) and added the logic to invoke BaseApplication::ButtonHandler on Buton0 press.
Testing
Tested the button events manually on 917SOC board.