[SL-TEMP] Fix commissioning with test credentials #366
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
added
the
sl-temp
mkardous-silabs
approved these changes
Mar 21, 2025
jmartinez-silabs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Devices fail to commission when not provisioned when build with GN
CHIP_DEVICE_CONFIG_ENABLE_EXAMPLE_CREDENTIALSwas replaced bySL_MATTER_ENABLE_EXAMPLE_CREDENTIALSwith new matter_support structure within the gn build config. However within matter 1.4 ProvisionStorageDefault.cpp and ProvisionStorageFlash.cpp the #ifdef to enable de example fallback have not being changed. Additionally Matter_Extension 2.5-1.4 and 2.6-1.4 still defineCHIP_DEVICE_CONFIG_ENABLE_EXAMPLE_CREDENTIALSSolution
To minimize the change and upgrade rules with in matter 1.4 release, Re-add CHIP_DEVICE_CONFIG_ENABLE_EXAMPLE_CREDENTIALS in GN build for the provisionStorageXXX sources.
SL_MATTER_ENABLE_EXAMPLE_CREDENTIALS is already present in matter 1.5 and 1 single upgrade rule can be done for matter extension 2.7.0-1.5
Testing
Successfully commission BRD4187C without provisioning with fix in place