[SL-UP] Adding app event for the LCD update #368
Merged
+185
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires an SL-UP tag/prefix |
chirag-silabs
changed the title
jmartinez-silabs
added
the
sl-up
|
Please add the required description. This PR description is not explaining the reason for the change and the Testing description is missing details. |
Sorry, forgot to add. It was created a draft PR so missed to update the description back, before posting it for a review |
jmartinez-silabs
approved these changes
Mar 27, 2025
arun-silabs
approved these changes
Mar 27, 2025
chirag-silabs
merged commit 085bd03
into
SiliconLabsSoftware:release_2.5-1.4
53 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Deadlock was observed when the LCD is reading any attributes which needs a lock and unlock chipstack, in some of the places the LCD update was called from the chip task which caused a deadlock.
Adding a LCD application event, which will post the event to the application for the LCD update.
This was found during the debugging of the issue: https://jira.silabs.com/browse/MATTER-4709
Tested locally with 917 SoC and NCP, all the LCD screen updates.