Revert "SWPROT-8953: libs2: Relax Werror for release, to be reverted" #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One would argue that libs2 warnings should not be addressed in the consumming project, but until a better architecture is in place, we can enable it to detect issues and help fixing them at the root. If for any reason having this patch is a problem, I encourage to cherry-pick the 1st Bypass change (that would be applied in next release) This reverts commit 436ef26. Origin: #37 Relate-to: #28 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Thomasdjb
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One would argue that libs2 warnings should not be addressed in the consumming project, but until a better architecture is in place, we can enable it to detect issues and help fixing them at the root. If for any reason having this patch is a problem,
I encourage to cherry-pick the 1st Bypass change
(that would be applied in next release)
This reverts commit 436ef26.
Origin: #27
Relate-to: #28
Change
Checklist