Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWPROT-8953: cmake: Drop vers_1.7.0 hardcoded version #42

Merged
merged 2 commits into from
Feb 19, 2025
Merged

SWPROT-8953: cmake: Drop vers_1.7.0 hardcoded version #42

merged 2 commits into from
Feb 19, 2025

Conversation

rzr
Copy link
Collaborator

@rzr rzr commented Feb 18, 2025 •
edited
Loading

Change

SWPROT-8953: ci: Pull annotated tag

After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: https://github.com/actions/checkout/pull/2081
Origin: https://github.com/SiliconLabsSoftware/z-wave-protocol-controller/pull/42
Relate-to: https://github.com/SiliconLabsSoftware/z-wave-protocol-controller/pull/35

Checklist

rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Feb 18, 2025
@rzr
SWPROT-8953: ci: Pull annotated tag
3feeb5d 
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Feb 18, 2025
@rzr
SWPROT-8953: cmake: Drop vers_1.7.0 hardcoded version
6f6259e 
Origin: SiliconLabsSoftware#42
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the build/review/main branch from 658bba5 to 6f6259e Compare February 18, 2025 09:42
rzr added 2 commits February 18, 2025 10:45
@rzr
SWPROT-8953: ci: Pull annotated tag
0150f74 
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr
SWPROT-8953: cmake: Drop vers_1.7.0 hardcoded version
de9c194 
Origin: SiliconLabsSoftware#42
Relate-to: Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the build/review/main branch from 6f6259e to de9c194 Compare February 18, 2025 09:46
@rzr rzr requested a review from silabs-aydogane February 18, 2025 09:46
@rzr rzr marked this pull request as draft February 18, 2025 09:47
@rzr rzr requested a review from Thomasdjb February 18, 2025 14:49
@rzr
Copy link
Collaborator Author

rzr commented Feb 18, 2025

@Thomasdjb this change along the next one :
#39

Will help you to download snapshot packages if you push tags to your fork eg: 1.7.1RC0${user}1

@rzr rzr marked this pull request as ready for review February 18, 2025 14:51
@rzr rzr merged commit 7cfac50 into SiliconLabsSoftware:main Feb 19, 2025
rzr added a commit that referenced this pull request Feb 19, 2025
@rzr
SWPROT-8953: ci: Pull annotated tag
414026a 
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: #42
Relate-to: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silabs-aydogane silabs-aydogane silabs-aydogane approved these changes

@Thomasdjb Thomasdjb Awaiting requested review from Thomasdjb

@silabs-JulienT silabs-JulienT Awaiting requested review from silabs-JulienT

@silabs-peterb silabs-peterb Awaiting requested review from silabs-peterb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzr @silabs-aydogane