tests: Fix a/z/c/z/test/zwave_command_class_time_parameters_test on U… #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiliconLabsSoftware#46 This test was previously bypassed, it is now working as expected. The reason it was failing is because mktime use timezone to set the tm structure that will be returned to the next step of step. Setting timezone to UTC (+0) solves the problem Bug-SiliconLabsSoftware: SiliconLabsSoftware#46 Origin: SiliconLabsSoftware#69 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
force-pushed
the
zpc/test/review/main
branch
from
00493b3 to
6e740ad
Compare
silabs-aydogane
approved these changes
Mar 17, 2025
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 17, 2025
SiliconLabsSoftware#46 This test was previously bypassed, it is now working as expected. The reason it was failing is because mktime use timezone to set the tm structure that will be returned to the next step of step. Setting timezone to UTC (+0) solves the problem Bug-SiliconLabsSoftware: SiliconLabsSoftware#46 Origin: SiliconLabsSoftware#69 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: Fix a/z/c/z/test/zwave_command_class_time_parameters_test UTC #46
This test was previously bypassed, it is now working as expected.
The reason it was failing is because mktime use timezone
to set the tm structure that will be returned to the next step of test.
Setting timezone to UTC (+0) solves the problem.
BTW, I am introducing an (unused) variable to keep the property tweek on fishy tests
if needed later, it could be removed on next cmake update.
Bug-SiliconLabsSoftware: #46
Origin: #69