Add AP mode support and error propagation improvements #360
Annotations
4 errors, 1 warning, and 10 notices
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L483
drivers/wifi/siwx917/siwx917_wifi.c:483 space prohibited before that close parenthesis ')'
|
Run Compliance Tests
Process completed with exit code 2.
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
SPACING: space prohibited before that close parenthesis ')'
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:483
|
check-warns
Process completed with exit code 1.
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- sl_si91x_rsp_wireless_info_t wlan_info = { };
+ sl_si91x_rsp_wireless_info_t wlan_info = {};
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:302
You may want to run clang-format on this change:
- sl_wifi_listen_interval_t listen_interval = { };
+ sl_wifi_listen_interval_t listen_interval = {};
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:327
You may want to run clang-format on this change:
- sl_wifi_ap_configuration_t conf = { };
+ sl_wifi_ap_configuration_t conf = {};
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:338
You may want to run clang-format on this change:
- if (siwx917_bandwidth(params->bandwidth) < 0 ) {
+ if (siwx917_bandwidth(params->bandwidth) < 0) {
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:484
You may want to run clang-format on this change:
- sl_net_set_credential(configuration.credential_id,
- default_wifi_ap_credential.type,
- (const void *)default_wifi_ap_credential.data,
- default_wifi_ap_credential.data_length);
+ sl_net_set_credential(configuration.credential_id, default_wifi_ap_credential.type,
+ (const void *)default_wifi_ap_credential.data,
+ default_wifi_ap_credential.data_length);
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:497
You may want to run clang-format on this change:
- ret = sl_net_set_credential(configuration.credential_id,
- SL_NET_WIFI_PSK, params->psk,
- params->psk_length);
+ ret = sl_net_set_credential(configuration.credential_id, SL_NET_WIFI_PSK,
+ params->psk, params->psk_length);
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:527
You may want to run clang-format on this change:
- sl_mac_address_t mac = { };
+ sl_mac_address_t mac = {};
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:562
You may want to run clang-format on this change:
-static sl_status_t siwx917_on_connect(sl_wifi_event_t event, void *data,
- uint32_t data_length, void *arg)
+static sl_status_t siwx917_on_connect(sl_wifi_event_t event, void *data, uint32_t data_length,
+ void *arg)
{
ARG_UNUSED(event);
struct siwx917_dev *sidev = arg;
- struct wifi_ap_sta_info sta_info = { };
+ struct wifi_ap_sta_info sta_info = {};
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:583
You may want to run clang-format on this change:
-static sl_status_t siwx917_on_disconnect(sl_wifi_event_t event, void *data,
- uint32_t data_length, void *arg)
+static sl_status_t siwx917_on_disconnect(sl_wifi_event_t event, void *data, uint32_t data_length,
+ void *arg)
{
ARG_UNUSED(event);
struct siwx917_dev *sidev = arg;
- struct wifi_ap_sta_info sta_info = { };
+ struct wifi_ap_sta_info sta_info = {};
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:602
You may want to run clang-format on this change:
- sl_wifi_statistics_t statistics = { };
+ sl_wifi_statistics_t statistics = {};
int ret;
__ASSERT(stats, "stats cannot be NULL");
ret = sl_wifi_get_statistics(FIELD_GET(SIWX917_INTERFACE_MASK, sidev->interface),
- &statistics);
+ &statistics);
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:624
You may want to run clang-format on this change:
- sl_wifi_set_callback(SL_WIFI_CLIENT_DISCONNECTED_EVENTS, siwx917_on_disconnect,
- sidev);
+ sl_wifi_set_callback(SL_WIFI_CLIENT_DISCONNECTED_EVENTS, siwx917_on_disconnect, sidev);
sidev->interface = sl_wifi_get_default_interface();
status = sl_wifi_get_mac_address(FIELD_GET(SIWX917_INTERFACE_MASK, sidev->interface),
- &sidev->macaddr);
+ &sidev->macaddr);
File:drivers/wifi/siwx917/siwx917_wifi.c
Line:658
You may want to run clang-format on this change:
- .scan = siwx917_scan,
- .connect = siwx917_connect,
- .disconnect = siwx917_disconnect,
- .ap_enable = siwx917_ap_enable,
- .ap_disable = siwx917_ap_disable,
+ .scan = siwx917_scan,
+ .connect = siwx917_connect,
+ .disconnect = siwx917_disconnect,
+ .ap_enable = siwx917_ap_enable,
+ .ap_disable = siwx917_ap_disable,
F
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L302
drivers/wifi/siwx917/siwx917_wifi.c:302
- sl_si91x_rsp_wireless_info_t wlan_info = { };
+ sl_si91x_rsp_wireless_info_t wlan_info = {};
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L327
drivers/wifi/siwx917/siwx917_wifi.c:327
- sl_wifi_listen_interval_t listen_interval = { };
+ sl_wifi_listen_interval_t listen_interval = {};
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L338
drivers/wifi/siwx917/siwx917_wifi.c:338
- sl_wifi_ap_configuration_t conf = { };
+ sl_wifi_ap_configuration_t conf = {};
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L484
drivers/wifi/siwx917/siwx917_wifi.c:484
- if (siwx917_bandwidth(params->bandwidth) < 0 ) {
+ if (siwx917_bandwidth(params->bandwidth) < 0) {
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L497
drivers/wifi/siwx917/siwx917_wifi.c:497
- sl_net_set_credential(configuration.credential_id,
- default_wifi_ap_credential.type,
- (const void *)default_wifi_ap_credential.data,
- default_wifi_ap_credential.data_length);
+ sl_net_set_credential(configuration.credential_id, default_wifi_ap_credential.type,
+ (const void *)default_wifi_ap_credential.data,
+ default_wifi_ap_credential.data_length);
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L527
drivers/wifi/siwx917/siwx917_wifi.c:527
- ret = sl_net_set_credential(configuration.credential_id,
- SL_NET_WIFI_PSK, params->psk,
- params->psk_length);
+ ret = sl_net_set_credential(configuration.credential_id, SL_NET_WIFI_PSK,
+ params->psk, params->psk_length);
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L562
drivers/wifi/siwx917/siwx917_wifi.c:562
- sl_mac_address_t mac = { };
+ sl_mac_address_t mac = {};
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L583
drivers/wifi/siwx917/siwx917_wifi.c:583
-static sl_status_t siwx917_on_connect(sl_wifi_event_t event, void *data,
- uint32_t data_length, void *arg)
+static sl_status_t siwx917_on_connect(sl_wifi_event_t event, void *data, uint32_t data_length,
+ void *arg)
{
ARG_UNUSED(event);
struct siwx917_dev *sidev = arg;
- struct wifi_ap_sta_info sta_info = { };
+ struct wifi_ap_sta_info sta_info = {};
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L602
drivers/wifi/siwx917/siwx917_wifi.c:602
-static sl_status_t siwx917_on_disconnect(sl_wifi_event_t event, void *data,
- uint32_t data_length, void *arg)
+static sl_status_t siwx917_on_disconnect(sl_wifi_event_t event, void *data, uint32_t data_length,
+ void *arg)
{
ARG_UNUSED(event);
struct siwx917_dev *sidev = arg;
- struct wifi_ap_sta_info sta_info = { };
+ struct wifi_ap_sta_info sta_info = {};
|
Run Compliance Tests:
drivers/wifi/siwx917/siwx917_wifi.c#L624
drivers/wifi/siwx917/siwx917_wifi.c:624
- sl_wifi_statistics_t statistics = { };
+ sl_wifi_statistics_t statistics = {};
int ret;
__ASSERT(stats, "stats cannot be NULL");
ret = sl_wifi_get_statistics(FIELD_GET(SIWX917_INTERFACE_MASK, sidev->interface),
- &statistics);
+ &statistics);
|
Loading