-
-
Notifications
You must be signed in to change notification settings - Fork 404
PatternElement Combinations + Conflicts Test #8138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/feature
Are you sure you want to change the base?
PatternElement Combinations + Conflicts Test #8138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing docs on all the methods. especially init
should have a very clear overview of what happens. see the function rework's FunctionArgumentParser for an example
great addition 🔥
src/test/java/org/skriptlang/skript/test/tests/lang/PatternParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/lang/PatternParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/lang/PatternParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ch/njol/skript/patterns/PatternConflictsTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just about ready
Problem
As Skript progresses further, adding more elements and patterns, ensuring minimal pattern conflictions can become increasingly harder to maintain with each new pattern added.
Solution
Adds
getAllCombinations
andabstract getCombinations
toPatternElement
to construct all possible combinations that can match.Adds JUnit
PatternConflictsTest
ensuringgetAllCombinations
correctly operates with manual inserted patterns and combinations.Additionally, this JUnit will go through every single registered element and it's patterns to construct all combinations, store them and check if a combination can be used for more than one element/pattern.
Testing Completed
JUnit
Supporting Information
TODO:
Some form of exclusionif only x and y then exclude
as can be seen withExprScriptsOld
andExprScripts
since only one can be usable at a time due to experiment enabling.Categorize the elements, so patterns used inStructure
s don't get marked as conflictions withExpression
s orEffect
sCompletes: none
Related: none