Skip to content

Conversation

Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Aug 23, 2025

Problem

Through the strive of simplification for allowing elements to be evaluated during parse time, if applicable, Conditions has not yet been modified to do so.

Solution

Makes Condition implement Simplifiable allowing it to be simplified during parse time after successful initialization and if applicable.

Adds SimplifiedCondition
Adds #fromCondition evaluating the original condition and prints a warning if applicable, then returning a SimplifiedCondition

Testing Completed

Manual testing

Supporting Information

N/A


Completes: none
Related: none

@Absolutionism Absolutionism requested review from a team as code owners August 23, 2025 19:41
@Absolutionism Absolutionism requested review from UnderscoreTud and Burbulinis and removed request for a team August 23, 2025 19:41
@Absolutionism Absolutionism added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Aug 23, 2025
@github-project-automation github-project-automation bot moved this to In Review in 2.13 Releases Aug 23, 2025
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
@Absolutionism Absolutionism requested a review from Efnilite August 23, 2025 20:33
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@Absolutionism Absolutionism requested a review from sovdeeth August 24, 2025 02:03
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last tweaks

@Absolutionism Absolutionism requested a review from sovdeeth August 26, 2025 22:30
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good addition 🔥

@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Aug 30, 2025
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
Status: Awaiting Merge
Development

Successfully merging this pull request may close these issues.

3 participants