-
-
Notifications
You must be signed in to change notification settings - Fork 404
SimplifiedCondition #8150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/feature
Are you sure you want to change the base?
SimplifiedCondition #8150
Conversation
src/main/java/org/skriptlang/skript/lang/script/ScriptWarning.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good addition 🔥
Problem
Through the strive of simplification for allowing elements to be evaluated during parse time, if applicable,
Condition
s has not yet been modified to do so.Solution
Makes
Condition
implementSimplifiable
allowing it to be simplified during parse time after successful initialization and if applicable.Adds
SimplifiedCondition
Adds
#fromCondition
evaluating the original condition and prints a warning if applicable, then returning aSimplifiedCondition
Testing Completed
Manual testing
Supporting Information
N/A
Completes: none
Related: none