Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation #15

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

janstaelensskyline
Copy link
Member

No description provided.

README.md Outdated

## **Primary Catalog YAML File**

If you wish to make adjustments based on the `auto-generated-catalog.yml` file, you can do so by:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrasing suggestion:

If you wish to make adjustments to the 'auto-generated-catalog.yml' file, you'll need to create a 'catalog.yml' file in the root folder of your repository.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a suggestion to leave out the ID field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID field can be included, or left out, same as all the other variables. I think I'd prefer adding that information in the readme to avoid people thinking they have to specificy and make the whole file.

README.md Outdated

If you wish to make adjustments based on the `auto-generated-catalog.yml` file, you can do so by:

- Creating a new `catalog.yml` file in the root of your repository and including only the modifications you want.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave out the suggestions to copy or start from scratch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left that out

Copy link
Member Author

@janstaelensskyline janstaelensskyline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ivehe can you verify the changes?

README.md Outdated

## **Primary Catalog YAML File**

If you wish to make adjustments based on the `auto-generated-catalog.yml` file, you can do so by:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID field can be included, or left out, same as all the other variables. I think I'd prefer adding that information in the readme to avoid people thinking they have to specificy and make the whole file.

README.md Outdated

If you wish to make adjustments based on the `auto-generated-catalog.yml` file, you can do so by:

- Creating a new `catalog.yml` file in the root of your repository and including only the modifications you want.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left that out

@janstaelensskyline janstaelensskyline merged commit 47c4b5b into main Dec 11, 2024
4 checks passed
@janstaelensskyline janstaelensskyline deleted the BetterAutoGenCustomizingDocs branch December 11, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants