-
Notifications
You must be signed in to change notification settings - Fork 267
Add neurostrip #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add neurostrip #2191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me on mac with the MRHead sample data.
One change request: you are installing the pip package when the module is first discovered, which slows down the application startup. Better practice is to only install the python packages after the user explicitly agrees and has been warned that it may take a few minutes. something like what's done here.
thanks, I adapted the pip_install logic here |
44f92cd
to
aeb67ce
Compare
The extension does not follow the required folder structure. Most importantly, the Icon URLs in CMakeLists.txt are incorrect (they give 404 error):
Extensions dependencies in the top-level CMakeLists.txt file are invalid. Since your extension does not depend on other Slicer extensions, you can set this to empty string. |
thanks @lassoan |
From https://github.com/Slicer/ExtensionsIndex/actions/runs/17519789080
|
aeb67ce
to
3413b31
Compare
3413b31
to
9bc3ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good now. Thank you for your contribution!
Consider adding a "How to cite" section to the documentation page with a link to related publication. |
@lassoan It appears neurostrip didn’t build successfully as seen at https://slicer.cdash.org/builds/3918009/configure. There could be possible additions to the automated checks to confirm CMakeLists.txt for the added module subdirectories. Or some other CMake build files check. |
New extension
Tier 1
Any extension that is listed in the Extensions Catalog must fulfill these requirements.
3d-slicer-extension
GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extension
in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettings
and in repository settings uncheckWiki
,Projects
, andDiscussions
(if they are currently not used).About
in the top-right corner of the repository main page and uncheckReleases
andPackages
(if they are currently not used)Tier 3
Community-supported extensions.
Tier 5
Critically important extensions, supported by Slicer core developers. New Slicer Stable Release is released only if all Tier 5 extension packages are successfully created on all supported platforms.