[Refactor] 토큰 관리 방식 변경 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongbin97
reviewed
Sep 29, 2024
Comment on lines
40
to
42
| if (request.getCookies() == null) { | ||
| return Optional.empty(); | ||
| } |
There was a problem hiding this comment.
request.getCookies()가 null이라면 for문을 순환하지 않아서 불필요한 부분인 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #33
📝 작업 내용
UserReader 관련 로직 변경
리프레시 토큰은 set-cookie 헤더에 넣어 보낸다
리프레시 토큰은 서버에서 관리하도록 변경
💬 리뷰 요구 사항