Overhaul of the once crate
#192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This almost completely overhauls the
once. We keepOnceVecandOnceBiVecand their API, but they are now backed by a more well-behaved data structure I call aGrove, for "grow vector". Bikeshedding welcome for the name.The new
MultiIndexed<K, V>struct is what I had in mind in #187 (comment). As the criterion benchmark shows, its performance is comparable to nestedOnceBiVecs for insertion, sometimes even faster. It also offers more flexibility like natively out-of-order insertions and arbitrarily negative coordinates.I added doctests, unit tests, proptests and tests using loom to test against strange thread scheduling. Also probably too much documentation. Sorry for the large diff