DefaultedRegistryValue, Taggable & StringRepresentable expansion #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponge into api-14-tag-expansion
MrHell228
force-pushed
the
api-14-tag-expansion
branch
from
1f37046 to
67e9df4
Compare
MrHell228
force-pushed
the
api-14-tag-expansion
branch
from
94ddce3 to
9c317f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
Half of current
Taggabletypes implementTaggable#isin different ways so I removed it and left it to defaulted method in API.Didn't touch
#isimpl that use builtinHolderbecause it's more effective.If we want impl to use
Holders for#isit should be inSpongeTaggableinterface for consistency between different types. Not sure if holders are wanted though.Also added missing mixin and fixed another one being in wrong place