Updating Notebooks #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Cell: 37, we were not importing the stingray.crosscorrelation
The variable at line ->152, should be window, and not uniform_window
it is typically recommended to use the built-in int type in Python rather than np.int for integers.
-seaborn-talk is now obsolete , and in the newer versions is replaced by seaborn-v0_8-talk. - font_manager.FontProperties was initialized without importing
these changes will help in ignoring changes made in the images of the notebooks, making the `git diff` relatively smaller and cleaner
|
@matteobachetti , |
matteobachetti
approved these changes
Feb 17, 2024
|
Good! May I ask you to re run the full notebooks, without committing the changes, to test that these modifications are sufficient to make them work? I will trust your word for it. |
|
@matteobachetti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Cell: 37, we were not importing the stingray.crosscorrelation