Introduce WebAuthnUserHandle to persist a truly random user handle
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the previous approach of hashing the users' primary key and implements the guidance in https://www.w3.org/TR/webauthn-3/#sctn-user-handle-privacy This yields better privacy, as there is no way now to link a user handle back to a user account. See the security note about a possible de-anonymization attack vector removed by this commit. When I originally wrote the handle generation code and said security note, I was under the impression that storing random bytes would have to be done on the user model. Requiring developers to implement a `WebAuthnUserHandle` mixin or the like in their custom user model to add this field. That would be more steps and add unwanted bloat. With the OneToOneField approach it works more transparently, with no effort required from the developer. Wish I thought of this from the beginning.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 13 13
Lines 683 709 +26
Branches 56 57 +1
=======================================
+ Hits 683 709 +26 ☔ View full report in Codecov by Sentry. |
Stormheg
force-pushed
the
feature/improve-user-handle-generation
branch
from
bc6037c to
17998c0
Compare
|
Need to figure out how this affects custom credential models and possibly adjust instructions to take into account a manual migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the previous approach of hashing the users' primary key and implements the guidance in https://www.w3.org/TR/webauthn-3/#sctn-user-handle-privacy
This yields better privacy, as there is no way now to link a user handle back to a user account. See the security note about a possible de-anonymization attack vector removed by this commit.
When I originally wrote the handle generation code and said security note, I was under the impression that storing random bytes would have to be done on the user model. Requiring developers to implement a
WebAuthnUserHandlemixin or the like in their custom user model to add this field. That would be more steps and add unwanted bloat.With the OneToOneField approach it works more transparently, with no effort required from the developer. Wish I thought of this from the beginning.