Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/WP-364: Ticket creation emails are not sent to 'cc' emails #1017

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

jmcmillenmusic
Copy link
Collaborator

Overview

There is a bug that prevents CC emails from receiving emails when a ticket is first created. CC emails actually receive emails when there are replies to a ticket, however.

Related

Changes

I edited the Ticket Modal to inform users that CC emails will only receive emails on ticket replies, not ticket creation.

Testing

No testing is required since this bug cannot be fixed locally.

UI

image

Notes

The change that we need to make must be done globally instead of locally. That change happens here. I'll reach out to the RT channel in Slack to see if we can make that change.

image

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.48%. Comparing base (698d919) to head (3483c54).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
- Coverage   72.68%   70.48%   -2.21%     
==========================================
  Files         327      538     +211     
  Lines       27692    33983    +6291     
  Branches     2204     2936     +732     
==========================================
+ Hits        20129    23954    +3825     
- Misses       7525     9829    +2304     
- Partials       38      200     +162     
Flag Coverage Δ
javascript 72.68% <100.00%> (ø)
unittests 60.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/src/components/Tickets/TicketCreateForm.jsx 85.15% <100.00%> (ø)
...portal/apps/onboarding/steps/project_membership.py 66.66% <ø> (ø)
server/portal/apps/tickets/api/views.py 80.64% <100.00%> (ø)

... and 209 files with indirect coverage changes

@jmcmillenmusic jmcmillenmusic changed the title Edited modal to warn users about CC email limitations Bug/WP-364: Ticket creation emails are not sent to 'cc' emails Nov 25, 2024
server/portal/apps/tickets/rtUtil.py Outdated Show resolved Hide resolved
server/portal/apps/tickets/api/views.py Outdated Show resolved Hide resolved
@chandra-tacc
Copy link
Collaborator

Note: unit tests are failing

@jmcmillenmusic
Copy link
Collaborator Author

Note: unit tests are failing

I got the failing test(s) to pass now.

@chandra-tacc chandra-tacc merged commit 0cf54fe into main Jan 8, 2025
5 of 6 checks passed
@chandra-tacc chandra-tacc deleted the bug/WP-364 branch January 8, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants