Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/WP-782: Resized View Full Path link in modals #1036

Merged
merged 11 commits into from
Jan 8, 2025
Merged

Bug/WP-782: Resized View Full Path link in modals #1036

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6398258
Resized View Full Path link in modals
Dec 12, 2024
8703aeb
Linted code
Dec 12, 2024
7778ead
Merge branch 'main' into bug/WP-782
jmcmillenmusic Dec 16, 2024
c3962b8
Correctly sized the View Full Path as-link button in modals
Dec 18, 2024
381aaee
Linted code
Dec 18, 2024
7d7c23c
Merge branch 'main' into bug/WP-782
jmcmillenmusic Dec 18, 2024
c623a96
Merge branch 'main' into bug/WP-782
wesleyboar Dec 20, 2024
f3b0cb7
fix: misspelling
wesleyboar Dec 20, 2024
e87e3e5
fix: my bad math
wesleyboar Dec 20, 2024
a9c89af
fix: combinedbreadcumbs css mis-compiles global class
wesleyboar Dec 20, 2024
15ed4cb
Merge branch 'main' into bug/WP-782
chandra-tacc Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion client/src/components/DataFiles/DataFilesBreadcrumbs/DataFilesBreadcrumbs.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
useSystems,
} from 'hooks/datafiles';
import truncateMiddle from 'utils/truncateMiddle';
import styles from '../../../components/_common/Button/Button.module.css';
jmcmillenmusic marked this conversation as resolved.
Show resolved Hide resolved

const BreadcrumbLink = ({
api,
Expand Down Expand Up @@ -195,7 +196,11 @@ const DataFilesBreadcrumbs = ({
)}
</div>
{systemName && api === 'tapis' && (
<Button type="link" onClick={openFullPathModal}>
<Button
type="link"
className={styles.modalButton}
onClick={openFullPathModal}
>
View Full Path
</Button>
)}
Expand Down
1 change: 1 addition & 0 deletions client/src/components/_common/Button/Button.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export const SIZE_MAP = {
long: 'width-long',
auto: 'width-auto',
small: 'size-small',
modalButton: 'modalButton',
jmcmillenmusic marked this conversation as resolved.
Show resolved Hide resolved
};
export const SIZES = [''].concat(Object.keys(SIZE_MAP));

Expand Down
4 changes: 4 additions & 0 deletions client/src/components/_common/Button/Button.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
font-size: 1rem;
}
jmcmillenmusic marked this conversation as resolved.
Show resolved Hide resolved

.modalButton {
font-size: 0.75rem !important;
}

jmcmillenmusic marked this conversation as resolved.
Show resolved Hide resolved
.icon--before {
composes: c-button__icon--before from '../../../styles/components/c-button--new.css';
}
Expand Down