Bug/WP-384: workspace search: handle scenario where id is missing in results

[chandra-tacc]

Overview

There are documents in the projects index which are old and do not have same schema as the search expects.
Some of those do not have id field.

Related

• WP-384

Changes

• Handle scenario where id is missing.

Testing

Setup for testing:

• exec into portal: docker exec -it core_portal_django bash

• Add 2 projects to index which could cause problems.

  • project with no "id" field

curl -H "Content-Type: application/json" -X POST http://core_portal_elasticsearch:9200/cep-dev-projects/_doc -d '
{"name": "CEP-foo","host": "cloud.data.tacc.utexas.edu","updated": "2023-11-11T00:00:00","owner": {"username": "foo","first_name": "foo","last_name": "foo","email": "foo@tacc.utexas.edu"},"title": "testfoo","description": "foo"}'

• project does not exist in tapis

curl -H "Content-Type: application/json" -X POST http://core_portal_elasticsearch:9200/cep-dev-projects/_doc -d '
{"id":"cep.project.CEP-foo1","path":"/corral-repl/tacc/aci/CEP/projects/CEP-foo1", "name": "CEP-foo1","host": "cloud.data.tacc.utexas.edu","updated": "2023-11-11T00:00:00","owner": {"username": "foo","first_name": "foo","last_name": "foo","email": "foo@tacc.utexas.edu"},"title": "testfoo1 buggy search","description": "foo"}'

Test

Go to shared workspaces

1. Without the fix, repro the error. search for test keyword. Below error is seen in UI
   

2. With the fix, search for test keyword. Both the above added projects are not seen in results and the UI does not show error.

3. Search for keyword from projects from your list, it should show up project results.

4. Search for a keyword not in project list, the results should be empty and not an error message in UI.

UI

Notes

[codecov]

Codecov Report

Merging #899 (6f58c61) into main (4d006aa) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         432      432           
  Lines       12393    12393           
  Branches     2581     2581           
=======================================
  Hits         7859     7859           
  Misses       4324     4324           
  Partials      210      210           

Flag	Coverage Δ
javascript	69.75% <ø> (ø)
unittests	56.94% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
server/portal/apps/projects/views.py	34.23% <0.00%> (ø)

[shayanaijaz]

LGTM

[rstijerina]

Nice fix 👍