Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tabs to no longer need a wrapping div to display content #505

Merged
1 commit merged into from
Sep 28, 2022
Merged

Fixed tabs to no longer need a wrapping div to display content #505

1 commit merged into from
Sep 28, 2022

Conversation

mumptastic
Copy link
Contributor

You no longer need a wrapping <div> tag to display content inside a tab.

@mumptastic mumptastic requested review from jeremythuff, a user and kaladay September 28, 2022 14:00
@ghost ghost linked an issue Sep 28, 2022 that may be closed by this pull request
Tabs Do Not Preserve All Projected Elements TAMULib/tamu-library-components#436
Open
kaladay
kaladay approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@kaladay kaladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was originally added specifically for tabs as well.
I see no problems after doing a deep investigation.

@ghost ghost merged commit 2311e1d into staging Sep 28, 2022
@kaladay kaladay deleted the 436_Tabs-Issues branch December 9, 2022 16:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladay kaladay kaladay approved these changes

@jeremythuff jeremythuff Awaiting requested review from jeremythuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs Do Not Preserve All Projected Elements
2 participants
@mumptastic @kaladay