fix: dont throw exception if a type can not be resolved #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderlinne
force-pushed
the
325-ensure-no-calls-between-modules-in-a-modulith
branch
from
91cf98c to
06c4990
Compare
Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
alexanderlinne
force-pushed
the
325-ensure-no-calls-between-modules-in-a-modulith
branch
from
06c4990 to
0ccf818
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 65.43% 65.49% +0.05%
==========================================
Files 256 257 +1
Lines 22946 23005 +59
Branches 1949 1953 +4
==========================================
+ Hits 15015 15066 +51
- Misses 7378 7386 +8
Partials 553 553 ☔ View full report in Codecov by Sentry. |
mak638
approved these changes
Jan 13, 2025
alexanderlinne
deleted the
325-ensure-no-calls-between-modules-in-a-modulith
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assemblies are loaded by path, there are cases where a dependent type cannot be resolved because the assembly dependency is not loaded in the current application domain. In this case, we create a stub type.
Fixes #325