fix(devcontainer): Add root user permissions for docker image build #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if its a issue with my PR or a existing issue but getting weird behavior when running In devcontainer I get an error complaining about DB not existing when it does exist locally. When running locally it hands on one e2e forever it seems. |
malexander15
requested review from
malexander15 and
chtzvt
and removed request for
malexander15
malexander15
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I cloned the repo and tried to build the
devcontainerI experienced an error failing the build. The error described pointed to a permissions issue while installing the container dependancies. Setting the USER to root in the docker image build fixes this issue.Added a non-root user to switch to after dependancies are installed to reduce privileges in the running container for enhanced security.
Pull request checklist
My code contains tests covering the code I modified(Not applicable)bin/checkI added significant changes and product updates to the changelog(Not applicable)Error Screenshot