fix(eslint-plugin) separate legacy and modern dts files #8972

Newbie012 · 2025-04-07T16:33:02Z

Aligned the build system with other packages by replacing the custom tsup config with standard modern/legacy build outputs. Moved output files from 'dist' to 'build' directory structure. Removed the patch-missing-export-equals.js script in favor of directly exporting the plugin. Added tsconfig.prod.json for production builds.

nx-cloud · 2025-04-07T16:33:33Z

View your CI Pipeline Execution ↗ for commit d2edcce.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	❌ Failed	10m 45s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 52s	View ↗

☁️ Nx Cloud last updated this comment at 2025-04-08 14:28:49 UTC

Newbie012 · 2025-04-07T16:35:31Z

package.json

@@ -100,8 +100,7 @@
      "@tanstack/vue-query": "workspace:*",
      "@tanstack/vue-query-devtools": "workspace:*",
      "@types/react": "^19.0.1",
-      "@types/react-dom": "^19.0.2",
-      "eslint": "$eslint"


I had to remove that line so I could use a specific version of eslint inside examples. If you have a better idea, please let me know.

Copilot

Copilot reviewed 9 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (9)

examples/react/eslint-legacy/.eslintrc: Language not supported
examples/react/eslint-legacy/.gitignore: Language not supported
examples/react/eslint-legacy/index.html: Language not supported
examples/react/eslint-legacy/package.json: Language not supported
examples/react/eslint-legacy/tsconfig.json: Language not supported
package.json: Language not supported
packages/eslint-plugin-query/package.json: Language not supported
packages/eslint-plugin-query/tsconfig.prod.json: Language not supported
pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

examples/react/eslint-legacy/src/index.tsx:51

Consider verifying that 'error' is an instance of Error before accessing 'error.message', to prevent potential runtime exceptions if the error structure differs.

<span>Error: {error.message}</span>

Newbie012 · 2025-04-07T16:39:57Z

@TkDodo It seems like there's something off with NX cache

TkDodo · 2025-04-07T17:52:28Z

the issue appears locally on this PR as well (try running pnpm run build:all) but it doesn’t appear on main, so I think there’s something wrong on this PR

examples/react/eslint-legacy/package.json

pkg-pr-new · 2025-04-07T17:57:27Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8972

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8972

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8972

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8972

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8972

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8972

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8972

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8972

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8972

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8972

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8972

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8972

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8972

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8972

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8972

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8972

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8972

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8972

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8972

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8972

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8972

commit: d2edcce

github-actions · 2025-04-07T17:57:28Z

Sizes for commit d2edcce:

Branch	Bundle Size
Main
This PR

TkDodo · 2025-04-07T18:27:51Z

there’s a legit error now:

root.tsup.config.js(3,1): error TS6133: 'esbuildPluginFilePathExtensions' is declared but its value is never read.

…/query into fix-eslint-plugin-modern-typing

codecov · 2025-04-08T08:00:55Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.30%. Comparing base (97c8d84) to head (e13738f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8972   +/-   ##
=======================================
  Coverage   44.30%   44.30%           
=======================================
  Files         202      202           
  Lines        8058     8058           
  Branches     1784     1785    +1     
=======================================
  Hits         3570     3570           
  Misses       4060     4060           
  Partials      428      428

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`88.08% <ø> (ø)`
@tanstack/eslint-plugin-query	`88.19% <0.00%> (ø)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`94.77% <ø> (ø)`
@tanstack/query-devtools	`3.61% <ø> (ø)`
@tanstack/query-persist-client-core	`57.73% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/react-query	`95.42% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.48% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.15% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.01% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TkDodo · 2025-04-08T12:52:25Z

examples/react/eslint-legacy/package.json

+  "name": "@tanstack/query-example-eslint-legacy",
+  "private": true,
+  "type": "module",
+  "scripts": {


if you want this example to be lintend in CI, you need to add a test:eslint script and we’ll have to remove the --exclude here:

query/package.json

Line 16 in 7e4e2e6

"test:eslint": "nx affected --target=test:eslint --exclude=examples/**",

Not sure why examples were excluded, most of them don’t have that task specified anyways 🤷

done, but it seems like something is off with packages that I didn't touch 😅

yeah sadly, some tests are flaky. I’ll ship it

…t command Add `test:eslint` script to react example package.json files to enable linting checks. Update the main `test:eslint` command to remove the exclusion of examples, ensuring linting is applied across the entire project.

thgreasi · 2025-04-09T16:22:22Z

Hi,
I think that this changed the result of require('@tanstack/eslint-plugin-query') from

{
  meta: { name: '@tanstack/eslint-plugin-query' },
  configs: {
    recommended: { plugins: [Array], rules: [Object] },
    'flat/recommended': [ [Object] ]
  },
  rules: {
    'exhaustive-deps': { create: [Function: create], defaultOptions: [], meta: [Object] },
    'stable-query-client': { create: [Function: create], defaultOptions: [], meta: [Object] },
    'no-rest-destructuring': { create: [Function: create], defaultOptions: [], meta: [Object] },
    'no-unstable-deps': { create: [Function: create], defaultOptions: [], meta: [Object] },
    'infinite-query-property-order': { create: [Function: create], defaultOptions: [], meta: [Object] },
    'no-void-query-fn': { create: [Function: create], defaultOptions: [], meta: [Object] }
  }
}

to

{
  default: {
    meta: { name: '@tanstack/eslint-plugin-query' },
    configs: {
      recommended: { plugins: [Array], rules: [Object] },
      'flat/recommended': [ [Object] ]
    },
    rules: {
      'exhaustive-deps': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'stable-query-client': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'no-rest-destructuring': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'no-unstable-deps': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'infinite-query-property-order': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'no-void-query-fn': { create: [Function: create], defaultOptions: [], meta: [Object] }
    }
  },
  plugin: {
    meta: { name: '@tanstack/eslint-plugin-query' },
    configs: {
      recommended: { plugins: [Array], rules: [Object] },
      'flat/recommended': [ [Object] ]
    },
    rules: {
      'exhaustive-deps': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'stable-query-client': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'no-rest-destructuring': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'no-unstable-deps': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'infinite-query-property-order': { create: [Function: create], defaultOptions: [], meta: [Object] },
      'no-void-query-fn': { create: [Function: create], defaultOptions: [], meta: [Object] }
    }
  }
}

I realize that the suggested way to import the package is

import pluginQuery from '@tanstack/eslint-plugin-query'

which if someone is using the TypeScript import helper, it will probably not be an issue at all, but I wanted to raise anyway that the result of the plain commonjs require() calls have changed, just in case it was missed.

Newbie012 · 2025-04-09T18:35:14Z

Thanks, I'll look into it

Newbie012 added 2 commits April 7, 2025 19:31

chore(example): eslint classic

1e6ee28

github-actions bot added the package: eslint-plugin-query label Apr 7, 2025

Newbie012 mentioned this pull request Apr 7, 2025

ESLint: Failed to load config "plugin:@tanstack/query/recommended" to extend from. #8968

Closed

ci: apply automated fixes

4dfdcca

Newbie012 commented Apr 7, 2025

View reviewed changes

Newbie012 requested a review from Copilot April 7, 2025 16:35

Copilot AI reviewed Apr 7, 2025

View reviewed changes

TkDodo reviewed Apr 7, 2025

View reviewed changes

examples/react/eslint-legacy/package.json Outdated Show resolved Hide resolved

fix: unique name for examples

c836a95

Newbie012 added 2 commits April 8, 2025 10:57

remove unused import

0e32455

Merge branch 'fix-eslint-plugin-modern-typing' of github.com:TanStack…

e13738f

…/query into fix-eslint-plugin-modern-typing

TkDodo reviewed Apr 8, 2025

View reviewed changes

TkDodo merged commit 7d3a1a3 into main Apr 8, 2025
4 of 5 checks passed

TkDodo deleted the fix-eslint-plugin-modern-typing branch April 8, 2025 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin) separate legacy and modern dts files #8972

fix(eslint-plugin) separate legacy and modern dts files #8972

Newbie012 commented Apr 7, 2025 •

edited

Loading

nx-cloud bot commented Apr 7, 2025 •

edited

Loading

Newbie012 Apr 7, 2025

Copilot AI left a comment

Newbie012 commented Apr 7, 2025

TkDodo commented Apr 7, 2025

pkg-pr-new bot commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

TkDodo commented Apr 7, 2025

codecov bot commented Apr 8, 2025

TkDodo Apr 8, 2025

Newbie012 Apr 8, 2025

TkDodo Apr 8, 2025

thgreasi commented Apr 9, 2025

Newbie012 commented Apr 9, 2025

fix(eslint-plugin) separate legacy and modern dts files #8972

fix(eslint-plugin) separate legacy and modern dts files #8972

Conversation

Newbie012 commented Apr 7, 2025 • edited Loading

nx-cloud bot commented Apr 7, 2025 • edited Loading

Newbie012 Apr 7, 2025

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Newbie012 commented Apr 7, 2025

TkDodo commented Apr 7, 2025

pkg-pr-new bot commented Apr 7, 2025 • edited Loading

github-actions bot commented Apr 7, 2025 • edited Loading

TkDodo commented Apr 7, 2025

codecov bot commented Apr 8, 2025

Codecov Report

TkDodo Apr 8, 2025

Choose a reason for hiding this comment

Newbie012 Apr 8, 2025

Choose a reason for hiding this comment

TkDodo Apr 8, 2025

Choose a reason for hiding this comment

thgreasi commented Apr 9, 2025

Newbie012 commented Apr 9, 2025

Newbie012 commented Apr 7, 2025 •

edited

Loading

nx-cloud bot commented Apr 7, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading