[FIX] 일반 검색 시 특수문자 무시하도록 수정 #248
Open
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaeAg
approved these changes
Jan 16, 2025
| @@ -280,12 +280,13 @@ public FilteredNovelsGetResponse getFilteredNovels(List<String> genreNames, Bool | |||
| @Transactional(readOnly = true) | |||
| public SearchedNovelsGetResponse searchNovels(String query, int page, int size) { | |||
| PageRequest pageRequest = PageRequest.of(page, size); | |||
| String searchQuery = query.replaceAll("\\s+", "").replaceAll("[^a-zA-Z0-9가-힣]", ""); | |||
There was a problem hiding this comment.
P5; 클라이언트 요청값을 형식에 맞게 변환하는 로직이 여기로 옮겨졌군용! 여기 있으니까 입력값을 필터링했을때 빈 문자열이 되는 경우에 검색을 아예 수행하지 않아서 성능적으로 이점이 있을 것 같네요! 굿굿
저도 궁금쓰 ㅎㅎ |
Kim-TaeUk
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
"울어 봐"라고 검색하면 "울어봐"로 띄어쓰기를 없앤 뒤, 모든 띄어쓰기를 없앤 작품 제목들 중 "울어봐"를 포함한 작품들을 반환합니다. 그렇기 때문에 "울어봐 빌어도"라고 검색하면 "울어봐빌어도"를 포함한 것들을 검색하기 때문에 "울어 봐, 빌어도 좋고"라는 작품은 검색 결과로 나타나지 않습니다.
그렇기 때문에 검색 시 특수문자를 무시하도록 검색 방식이 수정됐습니다.
또한 기획 측에서 결정한 내용에 따라 특수문자만을 가지고 검색 시 빈 리스트를 반환하도록 수정하였습니다.
To Reviewers
References