-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting of search results #4003
Sorting of search results #4003
Conversation
It is styled using a custom spinner style
773a82d
to
ce70619
Compare
ce70619
to
eece947
Compare
This is ready for review! |
Works great! One thing I think can be improved, from my initial test is, say if I have files such as Record_2023-12-07-02-19-49.mp4 |
In my understanding, ascending in sort by relevance should sort them from least to most relevant (since for example ascending in sort by size would be from small to large). I also think it's quite confusing, but logically it should be the correct order. Do you think inverting it would be more intuitive? |
Yea, descending relevance means least relevant at top and vice versa. I didn't notice this wasn't the original intention. |
Alright, then I will invert it 👍 (although I don't quite understand the logic) |
I pushed a commit to reverse the order - but could you maybe explain again why ascending relevance is from most to least relevant? I still don't quite get it. |
It's for the UX, just like you said, it'll be confusing for the user. Not all people using the app are technical, they won't see the relevance as a numerical from less to more. Let's try this way, if we get complaints from user that this behaviour is unexpected, we'll revert to your original implementation. |
…elevance Sorting of search results
…elevance Sorting of search results
Description
This PR adds the ability to sort the search results in the
SearchView
. For this, a button was added to theSearchView
which opens a dialog similar to the one for sorting directories.Additionally, to address issue #3357, this PR adds an option to sort the search results by relevance. This sorting is as described in this comment and is only available for sorting search results and not for directories.
To fully resolve issue #3357, the "old" search has to be embedded in the same search view as the new search view.
However, to avoid bloating this PR, I think it might be better to fix that separately.
Issue tracker
Addresses #3357
Automatic tests
Manual tests
Device:
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug
./gradlew spotlessCheck