-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request external login via Authorization endpoint #327
Draft
byewokko
wants to merge
58
commits into
main
Choose a base branch
from
feature/authorization-request-external-login
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # seacatauth/external_login/providers/generic.py # seacatauth/external_login/service.py # seacatauth/openidconnect/handler/discovery.py # seacatauth/openidconnect/service.py
# Conflicts: # seacatauth/authn/service.py # seacatauth/openidconnect/handler/authorize.py # seacatauth/openidconnect/service.py
Merged
# Conflicts: # seacatauth/authn/handler.py # seacatauth/authn/service.py # seacatauth/session/adapter.py # seacatauth/session/builders.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #316
Summary
acr_values
query parameter, e.g.acr_values=ext:google
.TODO
state
parameter instead ofredirect_uri
(store it in the login session)provider_id
path parameter (as it did before).GET /public/ext-login/{provider_id}?state={state}
which merely redirects to the external authorization endpoint. This is just a shorthand so that the ugly deep links are not so exposed.state
in payload