Improvement for BresenhamLine #6437 #6448
Open
+123
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinishajais
requested review from
DenizAltunkapan,
yanglbme,
vil02 and
alxkm
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6448 +/- ##
============================================
+ Coverage 75.04% 75.05% +0.01%
- Complexity 5534 5539 +5
============================================
Files 685 686 +1
Lines 19208 19215 +7
Branches 3706 3706
============================================
+ Hits 14414 14422 +8
Misses 4239 4239
+ Partials 555 554 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on improving the logic as asked by you.
👍 I have read [CONTRIBUTING.md]
👍 This pull request is all my own work -- I have not plagiarized it.
👍 All filenames are in PascalCase.
👍 All functions and variable names follow Java naming conventions.
👍 All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
👍 All new code is formatted with clang-format -i --style=file path/to/your/file.java