Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove detection of compiler #5426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove detection of compiler #5426

wants to merge 1 commit into from

Conversation

dudoslav
Copy link
Collaborator

Bootstrap script does not need to check if compiler is valid, since CMake can do it as well.


TYPE: NO_HISTORY
DESC: Remove detection of compiler from bootstrap script

@dudoslav dudoslav requested a review from ihnorton January 15, 2025 11:54
@dudoslav dudoslav self-assigned this Jan 15, 2025
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but tagging @teo-tsirpanis in case any concerns

Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would also remove new lines 194-213, and 217-218 and let CMake handle the compiler detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants