Hp calc

[omkelderman]

No description provided.

[Tillerino]

The calculation is wrong

…

On Fri, Oct 19, 2018, 11:33 Olle Kelderman ***@***.***> wrote: ------------------------------ You can view, comment on, or merge this pull request online at: #4 Commit Summary - add intellij stuff to gitignore - add hp calc File Changes - *M* osuApiConnector/.gitignore <https://github.com/Tillerino/osuApiConnector/pull/4/files#diff-0> (4) - *M* osuApiConnector/src/main/java/org/tillerino/osuApiModel/OsuApiBeatmap.java <https://github.com/Tillerino/osuApiConnector/pull/4/files#diff-1> (15) Patch Links: - https://github.com/Tillerino/osuApiConnector/pull/4.patch - https://github.com/Tillerino/osuApiConnector/pull/4.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABL9Zd2olp6lFUuq-mlhDsPDbyV3DKDEks5umZx4gaJpZM4XwAV1> .

[omkelderman]

welp, @ThePooN told me to use https://github.com/ThePooN/osu-ModPropertiesCalculator/blob/master/index.js so I did xD

[Tillerino]

I think a unit test or two would go a long way in convincing me.

…

On Fri, Oct 19, 2018, 15:26 Olle Kelderman ***@***.***> wrote: welp, @ThePooN <https://github.com/ThePooN> told me to use https://github.com/ThePooN/osu-ModPropertiesCalculator/blob/master/index.js so I did xD — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABL9ZScdj5lHHDZtB6RJTlRUvMAFXm8Lks5umdMXgaJpZM4XwAV1> .

[omkelderman]

well tbf, I have no freakin clue myself, so I wouldnt know where to pull testdata from... I can write unit tests sure, but I have no idea what data to test against. I'm just working on assumptions poon told me ¯\(ツ)/¯

[ThePooN]

Just use values that the game gives you to test against?

[omkelderman]

i'll try to wip up something when im home today