Skip to content

chore: align urls #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

chore: align urls #720

wants to merge 1 commit into from

Conversation

TomCools
Copy link
Contributor

DRAFT, DO NOT REVIEW YET, manual testing of UI ongoing.

Description of the change

Some URLs were not consistent,

  • Score analysis was a PUT call to analyse. This should be POST "score-analysis".
  • Starting a run should be POST to /<problem>, not POST to /<problem>/solve

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

@TomCools
chore: align urls
0fd2a53 
Some URLs were not consistent, for example "score-analysis".
@TomCools
Copy link
Contributor Author

Still need to modify the REST Guide HTML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TomCools