Skip to content

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Aug 20, 2025

No description provided.

@zepfred zepfred requested review from triceo and removed request for triceo August 20, 2025 17:24
@zepfred zepfred changed the title chore: simplify reachable values logic perf: improve entity value range logic for basic variables Aug 20, 2025
@triceo triceo self-requested a review August 21, 2025 05:23
Copy link
Collaborator

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say I don't understand how this does anything for basic variables.

On Slack, you said:

The concern separation property allowed me to create the reachable values for basic variables without any significant updates.

Is this that PR? If so, where exactly does it deal with basic variables?
And if so, why does the enterprise counterpart also only deal with list variables?

I am confused.

@zepfred zepfred marked this pull request as draft August 21, 2025 07:51
@zepfred
Copy link
Contributor Author

zepfred commented Aug 21, 2025

I have to say I don't understand how this does anything for basic variables.

On Slack, you said:

The concern separation property allowed me to create the reachable values for basic variables without any significant updates.

Is this that PR? If so, where exactly does it deal with basic variables? And if so, why does the enterprise counterpart also only deal with list variables?

I am confused.

This PR is still incomplete and only simplifies the ReachableValues class. Regarding the concern separation, I only needed to change the parameter type from ValueRangeManager::getReachableValues to GenuineVariableDescriptor to make it work for basic variables.

@triceo
Copy link
Collaborator

triceo commented Aug 21, 2025

This is still in progress.

The PR is now a draft, and that's fair. If it had been a draft from the beginning, I wouldn't have asked some of these questions.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants