-
Notifications
You must be signed in to change notification settings - Fork 150
perf: improve entity value range logic for basic variables #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to say I don't understand how this does anything for basic variables.
On Slack, you said:
The concern separation property allowed me to create the reachable values for basic variables without any significant updates.
Is this that PR? If so, where exactly does it deal with basic variables?
And if so, why does the enterprise counterpart also only deal with list variables?
I am confused.
core/src/main/java/ai/timefold/solver/core/impl/heuristic/selector/common/ReachableValues.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/heuristic/selector/common/ReachableValues.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/heuristic/selector/common/ReachableValues.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/heuristic/selector/common/ReachableValues.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/heuristic/selector/common/ReachableValues.java
Outdated
Show resolved
Hide resolved
...imefold/solver/core/impl/heuristic/selector/value/decorator/FilteringValueRangeSelector.java
Show resolved
Hide resolved
...imefold/solver/core/impl/heuristic/selector/value/decorator/FilteringValueRangeSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/score/director/ValueRangeManager.java
Outdated
Show resolved
Hide resolved
This PR is still incomplete and only simplifies the ReachableValues class. Regarding the concern separation, I only needed to change the parameter type from |
The PR is now a draft, and that's fair. If it had been a draft from the beginning, I wouldn't have asked some of these questions. |
2650091
to
dcfc118
Compare
dcfc118
to
2282dc1
Compare
|
No description provided.