Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint fixes & 2024 block removed #453

Merged
merged 1 commit into from
Jan 6, 2024
Merged

lint fixes & 2024 block removed #453

merged 1 commit into from
Jan 6, 2024

Conversation

Caleb-Cohen
Copy link
Member

Description

Proof of concepts to fix the tests. Needs to be refined a bit.

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

  • Is this related to a specific issue? If so, please specify:

Checklist:

  • This PR is up to date with the main branch, and merge conflicts have been resolved
  • I have executed npm run test and all tests have passed successfully or I have included details within my PR on the failure.
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Copy link
Contributor

@cblanken cblanken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
IMHO, we should think to rename the variable 'limitTo2023' to match the desired context. (line link here)
for example: 'limitTo2029' or better 'limitToEventMaxDate'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree and we can create a separate issue for this later just because its completely broken right now 😅

@intelagense
Copy link
Member

Closes #454

Copy link
Member

@intelagense intelagense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested locally and everything seems to work still.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree and we can create a separate issue for this later just because its completely broken right now 😅

@intelagense intelagense merged commit da310e3 into main Jan 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants