Skip to content

Commit

Permalink
strip-all (#22)
Browse files Browse the repository at this point in the history
Turns out that we don't seem to strip enough data from the binary which results in us going over the 200MB data limit for google play console. In order to upload to the play console, strip as much information. 

Now that we no longer specify `--target=elf64-little` I think our core issue should still be resolved.
  • Loading branch information
maxded authored Dec 20, 2024
1 parent 3df24ba commit 2a071ca
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions xbuild/src/command/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@ pub fn build(env: &BuildEnv) -> Result<()> {
.expect("Could not copy lib before stripping its debug symbols");

std::process::Command::new("strip")
// I'm told this should always be valid for Android, so use this as the target
.arg("--strip-debug")
.arg("--strip-all")
.arg(&lib)
.spawn()
.expect("Could not strip debug symbols from lib")
Expand Down

0 comments on commit 2a071ca

Please sign in to comment.