Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fixed] Long-existing non-latin IME bug fixed, please update & merge latest mobiledoc-kit #12268

Closed
xufangda opened this issue Oct 8, 2020 · 6 comments
Closed

[Bug Fixed] Long-existing non-latin IME bug fixed, please update & merge latest mobiledoc-kit #12268

xufangda opened this issue Oct 8, 2020 · 6 comments
Labels
affects:editor Work relating to the Koenig Editor affects:publishing

Comments

@xufangda
Copy link

xufangda commented Oct 8, 2020

Issue Summary

A long-lasting editor bug for typing in non-Latin characters has been repeatedly proposed in last two years but never resolved by mobiledoc-kit. This bug seriously damaged user experience for non-latin Ghost users. Now it has been fixed by mobiledoc-kit, please pull and merge latest mobiledoc-kit.

Description

Every time when non-Latin language user typing in Japanese / Chinese / Korea character, unwanted Latin character will appear. For the details of this bug, please refers to:
#9801
#9289
#9012
#8319

NOW THIS BUG HAS BEEN FIXED, YOU ONLY NEED TO PULL & UPDATE YOUR mobiledoc-kit!!
For people who don't know, mobiledoc-kit is the rich-text editor that ghost is using.

Solution

THIS BUG HAS BEEN FIXED BY mobiledoc-kit side
For people who don't know, mobiledoc-kit is the rich-text editor that ghost is using.

mobiledoc-kit MERGED the bugfix PR on 2020-07-15
fix IME bugs: mobiledoc-kit PR #738

mobiledoc-kit LATEST RELEASE on 2020-10-06

COULD YOU PLEASE PULL AND MERGE the latest mobiledoc-kit to GHOST?

This will save thousands of non-Latin users. This bug has been existing for 2 years, and pushed so many non-latin Ghost lovers away.

THANKS FOR FIXING THIS BUG!!!!
@tnmt tnmt mentioned this issue Oct 8, 2020
Merged
@matthanley matthanley added affects:editor Work relating to the Koenig Editor affects:publishing labels Oct 16, 2020
@knwgo
Copy link

knwgo commented Nov 13, 2020

STILL WAITING RELEASE

@tnmt
Copy link

tnmt commented Nov 17, 2020

I made PR TryGhost/mobiledoc-kit#15 to solve the Issue.

Could you check it?

@Windfarer
Copy link

They just don't care about CJK users.

@Ewocker
Copy link

Ewocker commented Nov 22, 2020

+1

@daniellockyer
Copy link
Member

daniellockyer commented Nov 23, 2020 •
edited
Loading

Hi all! Thank you for your patience. We've merged the upstream fix into our fork of mobiledoc-kit and bumped this in Ghost-Admin. You should see this getting released in the next version of Ghost 🙂

EDIT: this was released in v3.38.3 of Ghost!

daniellockyer added a commit to TryGhost/Admin that referenced this issue Nov 23, 2020
@daniellockyer
🐛 Fixed editor unable to handle non-latin IME languages
4d67bcc 
closes TryGhost/Ghost#12268

- see the referenced issue for discussion on the many issues with
  non-latin IME input
- this has been a long term bug which needed a patch in upstream
  mobiledoc-kit
- the fixes were released upstream in 0.12.5, so we've merged a
  contributor PR to our mobiledoc-kit fork and released v0.12.5-ghost.1
- in testing, this seems to fix a lot of the input issues people were
  seeing
@shincurry
Copy link
Contributor

Ghost v3.38.3 seems to solved this issue.

@raycon raycon mentioned this issue Nov 26, 2020
Open
@ghost ghost mentioned this issue Dec 27, 2020
Closed
@lifehome lifehome mentioned this issue Sep 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:editor Work relating to the Koenig Editor affects:publishing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@tnmt @daniellockyer @matthanley @shincurry @xufangda @Windfarer @Ewocker @knwgo